Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable download-cache support in edpm_iscsid role" #352

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Sep 20, 2023

Reverts #345

despite tests are green on ci, podman isn't installed by default on a "fresh" EL9 nodes and the edpm_podman role is executed later (in both install_os and configure_os playbooks) so local installs are now broken.

@openshift-ci openshift-ci bot requested review from dprince and slagle September 20, 2023 08:24
Copy link
Contributor

@rabi rabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, rabi, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gibizer,rabi,rebtoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rebtoor rebtoor merged commit f12c044 into main Sep 20, 2023
24 of 26 checks passed
@jpodivin jpodivin deleted the revert-345-download-cache-edpm_iscsid branch January 2, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants