Skip to content

Commit

Permalink
Merge pull request #699 from openshift-cherrypick-robot/cherry-pick-6…
Browse files Browse the repository at this point in the history
…95-to-18.0.0-proposed

[18.0.0-proposed] tripleo_cleanup: Fix a task that was always skipped and it shouldn't be
  • Loading branch information
openshift-merge-bot[bot] authored Jul 16, 2024
2 parents 6854004 + 5c78725 commit 30299cb
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 18 deletions.
26 changes: 13 additions & 13 deletions roles/edpm_tripleo_cleanup/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ edpm_remove_tripleo_unit_files: true

# Keep services listed
edpm_service_removal_skip_list:
- tripleo_swift_account_auditor
- tripleo_swift_account_reaper
- tripleo_swift_account_replicator
- tripleo_swift_account_server
- tripleo_swift_container_auditor
- tripleo_swift_container_replicator
- tripleo_swift_container_server
- tripleo_swift_container_updater
- tripleo_swift_object_auditor
- tripleo_swift_object_expirer
- tripleo_swift_object_replicator
- tripleo_swift_object_server
- tripleo_swift_object_updater
- tripleo_swift_account_auditor.service
- tripleo_swift_account_reaper.service
- tripleo_swift_account_replicator.service
- tripleo_swift_account_server.service
- tripleo_swift_container_auditor.service
- tripleo_swift_container_replicator.service
- tripleo_swift_container_server.service
- tripleo_swift_container_updater.service
- tripleo_swift_object_auditor.service
- tripleo_swift_object_expirer.service
- tripleo_swift_object_replicator.service
- tripleo_swift_object_server.service
- tripleo_swift_object_updater.service
7 changes: 2 additions & 5 deletions roles/edpm_tripleo_cleanup/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,9 @@
block:
- name: Get all services
ansible.builtin.service_facts:
- name: Filter for tripleo services
- name: Filter for tripleo services and skip the ones in skip list
ansible.builtin.set_fact:
tripleo_services: "{{ ansible_facts.services.keys() | select('contains', 'tripleo') }}"
- name: Filter services in skip list
ansible.builtin.set_fact:
tripleo_services: "{{ tripleo_services | reject('in', edpm_service_removal_skip_list ) }}"
tripleo_services: "{{ ansible_facts.services.keys() | select('contains', 'tripleo') | reject('in', edpm_service_removal_skip_list ) }}"

- name: Stop and disable tripleo services
tags:
Expand Down
1 change: 1 addition & 0 deletions zuul.d/projects.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,4 @@
- ^roles/edpm_ovn/*
- ^roles/edpm_neutron_metadata/*
- ^roles/edpm_pre_adoption_validation/*
- ^roles/edpm_tripleo_cleanup/*

0 comments on commit 30299cb

Please sign in to comment.