Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Added bootstrap service #476

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Added bootstrap service #476

merged 1 commit into from
Oct 21, 2023

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Oct 18, 2023 •
edited
Loading

Since in the configure-network playbook there were a lot of roles unrelated to the network configuration, we moved those roles into another playbook called bootstrap that should be called as the first role (right after download-cache, if/when used) in the deployment process.

https://issues.redhat.com/browse/OSP-28971

@rebtoor rebtoor requested review from slagle, fultonj and fao89 October 18, 2023 11:19
@openshift-ci openshift-ci bot requested review from abays and olliewalsh October 18, 2023 11:19
@fultonj
Copy link
Contributor

fultonj commented Oct 18, 2023 •
edited
Loading

Could this PR be updated to add bootstrap here too?

https://github.com/openstack-k8s-operators/dataplane-operator/blob/main/config/samples/dataplane_v1beta1_openstackdataplanedeployment_pre_ceph_hci.yaml#L11

otherwise, this is fine by me

fultonj added a commit to fultonj/architecture that referenced this pull request Oct 18, 2023
@fultonj
Add bootstrap service to VA1
c4854f6 
The depends-on adds the new `bootstrap` service. This
patch to architecture should be merged after it meges.

Depends-On: openstack-k8s-operators/dataplane-operator#476

Signed-off-by: John Fulton <[email protected]>
@fultonj fultonj mentioned this pull request Oct 18, 2023
Merged
@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 18, 2023

Could this PR be updated to add bootstrap here too?

https://github.com/openstack-k8s-operators/dataplane-operator/blob/main/config/samples/dataplane_v1beta1_openstackdataplanedeployment_pre_ceph_hci.yaml#L11

otherwise, this is fine by me

You were faster than me :)

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 18, 2023

At usual, kuttl tests are failing because the image used for dataplane pods is:

quay.io/openstack-k8s-operators/openstack-ansibleee-runner@sha256:2b33d35abd0ed7137647b7a19e037dda84f37d09dadad54cf4348fd7f2200c10

which is the latest image, not the one generated by the edpm-ansible PR.

fultonj
fultonj reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

config/samples/dataplane_v1beta1_openstackdataplanedeployment_pre_ceph_hci.yaml Show resolved Hide resolved
@rebtoor rebtoor mentioned this pull request Oct 18, 2023
Merged
@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 18, 2023

Logs of ansible runners are fine on both jobs:

baremetal: https://logserver.rdoproject.org/76/476/80168804f9c55f48a50c593abc7049883e830106/github-check/cifmw-crc-podified-edpm-baremetal/ee5cd20/ci-framework-data/logs/crc/pods/openstack_dataplane-deployment-bootstrap-openstack-edpm-ipam-hvd6q_71d6cfd2-13f4-47a1-9317-7a79a778a928/openstackansibleee/0.log

podified multinode: https://logserver.rdoproject.org/76/476/80168804f9c55f48a50c593abc7049883e830106/github-check/podified-multinode-edpm-deployment-crc/aeb8264/controller/ci-framework-data/logs/crc/pods/openstack_dataplane-deployment-bootstrap-openstack-edpm-9kgmf_94dea8ac-e498-4d69-82e4-08c48fb13aab/openstackansibleee/0.log

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0c983e16a69240419e1293e615ecc604

❌ openstack-k8s-operators-content-provider FAILURE in 8m 43s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ dataplane-operator-docs-preview SUCCESS in 1m 57s

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bd09ab5a90274d48b753eb686011fa51

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 05s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 31m 30s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 19m 20s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 53s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 19, 2023

recheck

@openshift-ci openshift-ci bot added the lgtm label Oct 19, 2023
@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 19, 2023

/test dataplane-operator-build-deploy-kuttl

@rebtoor
Added bootstrap service
5ef06a7 
Signed-off-by: Roberto Alfieri <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Oct 19, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8e01b876f57341c2abe7baf6ba342f23

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 50s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 23m 15s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 16m 26s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 47s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 20, 2023

recheck

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 20, 2023

/test dataplane-operator-build-deploy-kuttl

@openshift-ci openshift-ci bot added the lgtm label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, rebtoor, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fao89,rebtoor,slagle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f065b7e68f604d00bb004025d0750c12

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 46s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 19m 47s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 18m 41s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 48s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 20, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ba9a219ea8ba441b82c971f2941e93f8

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 36s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 21m 41s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 16m 53s
✔️ dataplane-operator-docs-preview SUCCESS in 1m 50s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 20, 2023 •
edited
Loading

recheck

(added depends-on with ci-framework)

@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#707 is needed.

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 20, 2023

recheck

@openshift-ci openshift-ci bot merged commit 6b8883f into openstack-k8s-operators:main Oct 21, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fultonj fultonj fultonj left review comments

@fao89 fao89 fao89 approved these changes

@slagle slagle slagle approved these changes

@abays abays Awaiting requested review from abays

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@slagle slagle

@fao89 fao89

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rebtoor @fultonj @slagle @fao89