Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Commit

Permalink
Cleanup golangci-lint
Browse files Browse the repository at this point in the history
Since the controller runtime and golang bump the golangci-lint github
action started to fail. However golangci-lint (and the rest of the
linters) also run in pre-commit both locally and in CI. So the github
action is removed. Also I took the opportunity to bump the golangci-lint
version to the newest that still supports 1.20. And removed disabled
checks that passing now.
  • Loading branch information
gibizer committed Feb 15, 2024
1 parent e426bf2 commit 8173bba
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 50 deletions.
42 changes: 0 additions & 42 deletions .github/workflows/golangci-lint.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,5 @@ linters:
- ginkgolinter
- gofmt
- govet
linters-settings:
revive:
rules:
# https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#unused-parameter
- name: unused-parameter
severity: warning
disabled: true
run:
timeout: 5m
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ repos:
exclude: ^vendor|^docs

- repo: https://github.com/golangci/golangci-lint
rev: v1.52.2
rev: v1.55.2
hooks:
- id: golangci-lint
args: ["-v"]

0 comments on commit 8173bba

Please sign in to comment.