Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Manila support in DCN jobs #2573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions roles/ci_dcn_site/templates/service-values.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,14 @@ data:
{% endif %}
{% endfor %}
manila:
enabled: false
enabled: true
manilaAPI:
customServiceConfig: |
[DEFAULT]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In DCN, according to https://github.com/openstack-k8s-operators/architecture/tree/main/examples/dt/dcn, there are three Ceph clusters..

You'd need the appropriate Ceph configuration plugged to a specific instance of "manila-share"; and a corresponding extra-mount with the ceph secret.

See how cinder volume is configured beginning line 27 in this file..

We need a change to the "architecture" repo that enables setting "ManilaShares" similar to CinderVolumes so we can do that..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, and also, we might need to change manilaShares here to iterate over the AZs:

manilaShares:
{% for _ceph in _ceph_vars_list %}
    {{ _ceph.cifmw_ceph_client_cluster }}:
      customServiceConfig: |
          [DEFAULT]
          enabled_share_backends = cephfs
          enabled_share_protocols = cephfs
          [cephfs]
          driver_handles_share_servers = False
          share_backend_name = cephfs
          share_driver = manila.share.drivers.cephfs.driver.CephFSDriver
          cephfs_conf_path = /etc/ceph/{{ _ceph.cifmw_ceph_client_cluster }}.conf
          cephfs_cluster_name = {{ _ceph.cifmw_ceph_client_cluster }}
          cephfs_auth_id=openstack
          cephfs_volume_mode = 0755
          cephfs_protocol_helper_type = CEPHFS
{% endfor %}

enabled_share_protocols=nfs,cephfs
manilaShares:
share1:
{% for _ceph in _ceph_vars_list %}
{{ _ceph.cifmw_ceph_client_cluster }}:
customServiceConfig: |
[DEFAULT]
enabled_share_backends = cephfs
Expand All @@ -108,11 +109,13 @@ data:
driver_handles_share_servers = False
share_backend_name = cephfs
share_driver = manila.share.drivers.cephfs.driver.CephFSDriver
cephfs_conf_path = /etc/ceph/ceph.conf
cephfs_conf_path = /etc/ceph/az{{ loop.index }}.conf
cephfs_cluster_name = ceph
cephfs_auth_id=openstack
cephfs_volume_mode = 0755
cephfs_protocol_helper_type = CEPHFS
storage_availability_zone = {{ _ceph.cifmw_ceph_client_cluster }}
{% endfor %}
neutron:
template:
customServiceConfig: |
Expand Down