Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate test_operator artifacts basedir for update test run #2196

Conversation

ciecierski
Copy link
Contributor

Save test_operator test runs to separate test_operator_update dir to prevent overriding test_operators deployment run results with update run.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Copy link

github-actions bot commented Aug 5, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft August 5, 2024 11:54
Save test_operator test runs to seperate test_operator_update dir
to prevent overriding test_operators deployment run results with
update run.
@ciecierski ciecierski marked this pull request as ready for review August 6, 2024 09:18
@raukadah
Copy link
Contributor

raukadah commented Aug 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

This makes sense. We want to store the logs into a separate folder when running the test-operator after an update.

@lpiwowar
Copy link
Contributor

lpiwowar commented Aug 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit cba6d9a into openstack-k8s-operators:main Aug 6, 2024
5 checks passed
@raukadah
Copy link
Contributor

raukadah commented Aug 7, 2024

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@raukadah: new pull request created: #2207

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants