Change order of if-elif conditionals in set_openstack_containers template #2187
Conversation
|
Thanks for the PR! ❤️ |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aecff13a44474dcb849599da02fb134e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 52s |
ciecierski
force-pushed
the
set-container-role-fix
branch
from
1c868cf to
745c66d
Compare
|
/approve |
|
/lgtm |
|
/hold |
ciecierski
force-pushed
the
set-container-role-fix
branch
from
745c66d to
b004460
Compare
…late To update both container tags and ansiblee RELATED_VARS of openstack-operator in the same set_openstack_containers role run both cifmw_set_openstack_containers_tag and cifmw_set_openstack_containers_overrides are defined. cifmw_set_openstack_containers_overrides if conditional must be checked later, because otherwise container_tags modifications are all skipped.
ciecierski
force-pushed
the
set-container-role-fix
branch
from
b004460 to
7a15911
Compare
|
/cancel hold |
|
/hold cancel |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino, raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3c43d9f49596403e904bee982b8ee8d5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 55s |
|
recheck |
openshift-merge-bot
bot
merged commit 34b2b1c
into
openstack-k8s-operators:main
|
/cherry-pick 18.0.0-proposed |
|
@ciecierski: new pull request created: #2201 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
To update both container tags and ansiblee RELATED_VARS of openstack-operator in the same set_openstack_containers role run both cifmw_set_openstack_containers_tag and cifmw_set_openstack_containers_overrides are defined. cifmw_set_openstack_containers_overrides if conditional must be checked later, because otherwise container_tags modifications are all skipped.
As a pull request owner and reviewers, I checked that: