Ensure ocp is reachable from ocpbm before deploying #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
pablintino
force-pushed
the
shiftstack/ocpbm-connectivity
branch
from
1ae0913 to
ae249a1
Compare
pablintino
force-pushed
the
shiftstack/ocpbm-connectivity
branch
from
ae249a1 to
8085350
Compare
|
This PR was successfully tested in a shift on stack deployment |
rebtoor
reviewed
Aug 5, 2024
reproducer.yml
Outdated
| when: | ||
| - cifmw_deploy_architecture | default(false) | bool | ||
| no_log: "{{ cifmw_nolog | default(true) | bool }}" | ||
| async: "{{ 7200 + cifmw_test_operator_timeout|default(3600) }}" # 2h should be enough to deploy EDPM and rest for tests. |
There was a problem hiding this comment.
Suggested change
| async: "{{ 7200 + cifmw_test_operator_timeout|default(3600) }}" # 2h should be enough to deploy EDPM and rest for tests. | |
| async: "{{ 7200 + cifmw_test_operator_timeout | default(3600) }}" # 2h should be enough to deploy EDPM and rest for tests. |
let's improve jinja spacing
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since we now run the shifstack deployment using the reproducer by toggling `cifmw_deploy_architecture` we must ensure the iptables change we do is done before reaching the deployment step.
pablintino
force-pushed
the
shiftstack/ocpbm-connectivity
branch
from
8085350 to
7e6d580
Compare
|
/lgtm |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now run the shifstack deployment using the reproducer by toggling
cifmw_deploy_architecturewe must ensure the iptables change we do is done before reaching the deployment step.As a pull request owner and reviewers, I checked that: