Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RDO third party check job for whitebox neutron tempest plugin #2056

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Jul 10, 2024

This pr adds a 4 node (one controller, 2 compute , 1 extracted crc) multinode edpm zuul job to test whitebox neutron tempest plugin opendev patches.

It adds:

  • podified-multinode-edpm-deployment-crc-2comp parent job
  • centos-9-medium-2x-centos-9-crc-extracted-2-36-0-xxl nodeset
  • whitebox-neutron-tempest-plugin-podified-multinode-edpm-deployment-crc-2comp

This patch will run as a rdo third party job in rdo openstack-check pipeline[1].

Links:
[1]. https://review.rdoproject.org/r/c/config/+/53918

As a pull request owner and reviewers, I checked that:

Build succeeded.
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b59f4057362e43acaaffb8dd2883955a

noop https://softwarefactory-project.io/zuul/t/rdoproject.org/build/12a8f3ad0d67496aae3d988bfc5d67f9 : SUCCESS in 0s
openstack-meta-content-provider https://softwarefactory-project.io/zuul/t/rdoproject.org/build/389e844486e74067b56c3704967173ab : SUCCESS in 3h 44m 01s
whitebox-neutron-tempest-plugin-podified-multinode-edpm-deployment-crc-2comp https://softwarefactory-project.io/zuul/t/rdoproject.org/build/6073cdb501424749898da85aca4fb718 : SUCCESS in 2h 48m 04s

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch main. The
problem was:

required key not provided @ data['nodes'][2]['label']

The problem appears in the the "centos-9-medium-2x-centos-9-crc-extracted-2-36-0-xxl" nodeset stanza:

nodeset:
name: centos-9-medium-2x-centos-9-crc-extracted-2-36-0-xxl
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo-medium
- name: compute-0
label: cloud-centos-9-stream-tripleo
- name: compute-1
- name: crc
...

in "openstack-k8s-operators/ci-framework/zuul.d/nodeset.yaml@main", line 308

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from e62656f to 2b210de Compare July 10, 2024 00:38
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch main. The
problem was:

required key not provided @ data['nodes'][2]['label']

The problem appears in the the "centos-9-medium-2x-centos-9-crc-extracted-2-36-0-xxl" nodeset stanza:

nodeset:
name: centos-9-medium-2x-centos-9-crc-extracted-2-36-0-xxl
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo-medium
- name: compute-0
label: cloud-centos-9-stream-tripleo
- name: compute-1
- name: crc
...

in "openstack-k8s-operators/ci-framework/zuul.d/nodeset.yaml@main", line 308

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 2b210de to 4a960e3 Compare July 10, 2024 00:40
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/01fa113edf8740368bcdabbcaf10537c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 05s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 08m 31s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 26s
cifmw-pod-pre-commit FAILURE in 7m 40s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 28s

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 4a960e3 to 0fe2103 Compare July 10, 2024 10:41
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5b36a37f64604cbea11050eef1f4a7af

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 04s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 32s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 03s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 45s
cifmw-pod-pre-commit FAILURE in 7m 51s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 49s

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 0fe2103 to c6a9d6d Compare July 11, 2024 13:03
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6dac28884b91474fa78a52ee8a3d531a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 10s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 21s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 47s
cifmw-pod-pre-commit FAILURE in 8m 07s
cifmw-pod-zuul-files FAILURE in 5m 01s

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from c6a9d6d to 8ca3265 Compare July 11, 2024 23:55
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/994b22fdfdb54188a993ebed7a4b862e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 09s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 17s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 23m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 31s
cifmw-pod-pre-commit FAILURE in 8m 04s
cifmw-pod-zuul-files FAILURE in 4m 49s

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 8ca3265 to 1c8d34c Compare July 12, 2024 01:55
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3e181f3ebedd48b3956c6fad933085ec

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 04s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 02s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 27s
cifmw-pod-pre-commit FAILURE in 7m 51s
cifmw-pod-zuul-files FAILURE in 4m 40s

Copy link
Contributor

openshift-ci bot commented Jul 14, 2024

@m-blue-m: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 1c8d34c to a400491 Compare July 15, 2024 01:07
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/344801fd151144a3a33f0620006bff85

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 20s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 57s
cifmw-pod-pre-commit FAILURE in 7m 39s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 50s

Warning:
Zuul encountered a deprecated syntax while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch main. The
problem was:

All regular expressions must conform to RE2 syntax, but an
expression using the deprecated Perl-style syntax has been detected.
Adjust the configuration to conform to RE2 syntax.

The RE2 syntax error is: invalid perl operator: (?!

The problem appears in the "files" attribute
of the "cifmw-data-plane-adoption-osp-17-to-extracted-crc" job stanza:

job:
name: cifmw-data-plane-adoption-osp-17-to-extracted-crc
parent: data-plane-adoption-osp-17-to-extracted-crc
files:
- ^playbooks/01-bootstrap.yml
- ^playbooks/02-infra.yml
- ^playbooks/06-deploy-edpm.yml
- ^roles/discover_latest_image/(?!meta|README|molecule).*
- ^roles/edpm_prepare/(?!meta|README|molecule).*
...

in "openstack-k8s-operators/ci-framework/zuul.d/adoption.yaml@main", line 99

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from a400491 to 1fabb7b Compare July 15, 2024 09:33
- name: controller
label: cloud-centos-9-stream-tripleo-medium
- name: compute-0
label: cloud-centos-9-stream-tripleo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raukadah ,

computes needed about 120G per compute to test tenant VMs, otherwise we see many test cases failing with 5xx status.
In downstream jobs we changed to '*xxl' nodes, and used 'cifmw_block_device_size: 40G' which used 3 cephs to use 120G in total.
Is node of type 'cloud-centos-9-stream-tripleo' sufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, 'cloud-centos-9-stream-tripleo is not sufficient. As discussed on slack. One of the skipped tests is failing with no valid host. As it needs a larger node. We will do a follow up on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so 120G shoudl not be requried if your not setting the concurance really high.

the concurance in the job should be between 4-6 i belive the test operator is using someing like 10 by default which is not reasonable for the size of compute nodes we use

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/60a08102de1d43bba3ad53295f4fc309

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 38s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 22s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 37s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 22s
cifmw-pod-pre-commit FAILURE in 8m 20s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 21s

Warning:
Zuul encountered a deprecated syntax while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch main. The
problem was:

All regular expressions must conform to RE2 syntax, but an
expression using the deprecated Perl-style syntax has been detected.
Adjust the configuration to conform to RE2 syntax.

The RE2 syntax error is: invalid perl operator: (?!

The problem appears in the "files" attribute
of the "cifmw-data-plane-adoption-osp-17-to-extracted-crc" job stanza:

job:
name: cifmw-data-plane-adoption-osp-17-to-extracted-crc
parent: data-plane-adoption-osp-17-to-extracted-crc
files:
- ^playbooks/01-bootstrap.yml
- ^playbooks/02-infra.yml
- ^playbooks/06-deploy-edpm.yml
- ^roles/discover_latest_image/(?!meta|README|molecule).*
- ^roles/edpm_prepare/(?!meta|README|molecule).*
...

in "openstack-k8s-operators/ci-framework/zuul.d/adoption.yaml@main", line 99

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 1fabb7b to 16a0aec Compare July 16, 2024 00:41
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/543135aa4fcc471cb650d02485df58e7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 29s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 18m 27s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 36s
cifmw-pod-pre-commit FAILURE in 8m 25s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 38s

Warning:
Zuul encountered a deprecated syntax while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch main. The
problem was:

All regular expressions must conform to RE2 syntax, but an
expression using the deprecated Perl-style syntax has been detected.
Adjust the configuration to conform to RE2 syntax.

The RE2 syntax error is: invalid perl operator: (?!

The problem appears in the "files" attribute
of the "cifmw-data-plane-adoption-osp-17-to-extracted-crc" job stanza:

job:
name: cifmw-data-plane-adoption-osp-17-to-extracted-crc
parent: data-plane-adoption-osp-17-to-extracted-crc
files:
- ^playbooks/01-bootstrap.yml
- ^playbooks/02-infra.yml
- ^playbooks/06-deploy-edpm.yml
- ^roles/discover_latest_image/(?!meta|README|molecule).*
- ^roles/edpm_prepare/(?!meta|README|molecule).*
...

in "openstack-k8s-operators/ci-framework/zuul.d/adoption.yaml@main", line 99

@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 16a0aec to c9358cc Compare July 16, 2024 12:28
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f3331e1402f54fb0bd612893d2698104

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 38m 24s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 31s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 16s
cifmw-pod-pre-commit FAILURE in 8m 06s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 06s

Warning:
Zuul encountered a deprecated syntax while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch main. The
problem was:

All regular expressions must conform to RE2 syntax, but an
expression using the deprecated Perl-style syntax has been detected.
Adjust the configuration to conform to RE2 syntax.

The RE2 syntax error is: invalid perl operator: (?!

The problem appears in the "files" attribute
of the "cifmw-data-plane-adoption-osp-17-to-extracted-crc" job stanza:

job:
name: cifmw-data-plane-adoption-osp-17-to-extracted-crc
parent: data-plane-adoption-osp-17-to-extracted-crc
files:
- ^playbooks/01-bootstrap.yml
- ^playbooks/02-infra.yml
- ^playbooks/06-deploy-edpm.yml
- ^roles/discover_latest_image/(?!meta|README|molecule).*
- ^roles/edpm_prepare/(?!meta|README|molecule).*
...

in "openstack-k8s-operators/ci-framework/zuul.d/adoption.yaml@main", line 99

@raukadah raukadah force-pushed the edpm_rdo_third_party branch 4 times, most recently from 645f837 to 77060d8 Compare July 17, 2024 03:42
@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 653fa67 to a844536 Compare July 31, 2024 06:43
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8ff5793041f642cfb178a9f78993007a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 09s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 46s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 11s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
cifmw-pod-pre-commit FAILURE in 7m 25s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 09s

^whitebox_neutron_tempest_plugin.tests.scenario.test_qos.*external
^whitebox_neutron_tempest_plugin.tests.scenario.test_router_flavors
^whitebox_neutron_tempest_plugin.tests.scenario.test_vlan_transparency.ProviderNetworkVlanTransparencyTest
whitebox_neutron_tempest_plugin.tests.scenario.test_security_group_logging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes.
I noticed a small duplicate line in IncludeList for test_security_group_logging.

cifmw_test_operator_tempest_extra_images:
# TODO(chandan): Replace rocky qcow2 url once rhos-ops hosts it
- URL: "https://chandankumar.fedorapeople.org/rocky9_latest_neutron_whitebox.qcow2"
name: custom_neutron_guest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that should be added to fix image issue as Lukas suggested in OSPTH-8989:
name: custom_neutron_guest
diskFormat: "qcow2" <--- HERE

@raukadah raukadah force-pushed the edpm_rdo_third_party branch 2 times, most recently from 6c2ee24 to bb0a3cf Compare July 31, 2024 10:44
@raukadah raukadah force-pushed the edpm_rdo_third_party branch from bb0a3cf to d98ad56 Compare July 31, 2024 14:42
@raukadah raukadah force-pushed the edpm_rdo_third_party branch from d98ad56 to 2297059 Compare August 1, 2024 07:02
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e2ad4396c77049a0ad6f613db69a0b93

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 43s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 38s
cifmw-pod-pre-commit FAILURE in 7m 19s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 43s

This pr adds a 4 node (one controller, 2 compute , 1 extracted crc)
multinode edpm zuul job to test whitebox neutron tempest plugin opendev
patches.

It adds:
- podified-multinode-edpm-deployment-crc-2comp parent job
- centos-9-medium-2x-centos-9-crc-extracted-2-36-0-xxl nodeset
- whitebox-neutron-tempest-plugin-podified-multinode-edpm-deployment-crc-2comp

This patch will run as a rdo third party job in rdo openstack-check
pipeline[1].

Links:
[1]. https://review.rdoproject.org/r/c/config/+/53918

Signed-off-by: Chandan Kumar <[email protected]>
@raukadah raukadah force-pushed the edpm_rdo_third_party branch from 2297059 to 8162ee8 Compare August 1, 2024 13:01
@karelyatin
Copy link
Contributor

/lgtm

@m-blue-m
Copy link
Contributor

m-blue-m commented Aug 1, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

@m-blue-m: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@viroel
Copy link
Collaborator

viroel commented Aug 1, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0594f96 into main Aug 1, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the edpm_rdo_third_party branch August 1, 2024 18:47
rdoproject pushed a commit to rdo-infra/review.rdoproject.org-config that referenced this pull request Aug 2, 2024
Depends-On: openstack-k8s-operators/ci-framework#2056

Change-Id: I587cd1ac2ab603ac2bde1f00f184c8078dd3d82b
Signed-off-by: Chandan Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants