Skip to content

Commit

Permalink
[test-operator] Move away from Jobs to Pods
Browse files Browse the repository at this point in the history
With this PR [1] the test operator dropped the usage of OCP Jobs for
spawning of the test pods.

This change updates the test-operator role so that it works with the
new version of the test-operator that spawns test pods directly through
the OCP Pods object.

[1] openstack-k8s-operators/test-operator#266
  • Loading branch information
lpiwowar committed Dec 17, 2024
1 parent ff9f827 commit 46c954f
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 23 deletions.
36 changes: 18 additions & 18 deletions roles/test_operator/tasks/run-test-operator-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,35 +37,35 @@
definition: "{{ test_operator_cr }}"
when: not cifmw_test_operator_dry_run | bool

- name: Wait for the last job to be Completed - {{ run_test_fw }}
- name: Wait for the last Pod to be Completed - {{ run_test_fw }}
kubernetes.core.k8s_info:
kubeconfig: "{{ cifmw_openshift_kubeconfig }}"
api_key: "{{ cifmw_openshift_token | default(omit) }}"
context: "{{ cifmw_openshift_context | default(omit) }}"
namespace: "{{ cifmw_test_operator_namespace }}"
kind: Job
kind: Pod
label_selectors:
- "workflowStep={{ [(test_operator_workflow | length) - 1, 0] | max }}"
- "instanceName={{ test_operator_job_name }}"
- "instanceName={{ test_operator_instance_name }}"
retries: "{{ (cifmw_test_operator_timeout / 10) | round | int }}"
delay: 10
until: >
testjob.resources[0].status.succeeded | default(0) | int >= 1 or
testjob.resources[0].status.failed | default(0) | int >= 1
testpod.resources[0].status.phase | default(omit) == "Succeeded" or
testpod.resources[0].status.phase | default(omit) == "Failed"
ignore_errors: true
register: testjob
register: testpod
when: not cifmw_test_operator_dry_run | bool

- name: Check whether timed out - {{ run_test_fw }}
ansible.builtin.set_fact:
testjob_timed_out: >-
{{ testjob.attempts == (cifmw_test_operator_timeout / 10) | round | int }}
testpod_timed_out: >-
{{ testpod.attempts == (cifmw_test_operator_timeout / 10) | round | int }}
when: not cifmw_test_operator_dry_run | bool

- name: Collect logs
when:
- not cifmw_test_operator_dry_run | bool
- not testjob_timed_out
- not testpod_timed_out
block:
- name: Reset volumes and volume_mounts to an empty list
ansible.builtin.set_fact:
Expand All @@ -79,7 +79,7 @@
context: "{{ cifmw_openshift_context | default(omit)}}"
kind: PersistentVolumeClaim
label_selectors:
- "instanceName={{ test_operator_job_name }}"
- "instanceName={{ test_operator_instance_name }}"
register: logsPVCs

- name: Set up volume mounts and volumes for all PVCs
Expand All @@ -88,7 +88,7 @@
{{
(volume_mounts | default([])) + [{
'name': "logs-volume-" ~ index,
'mountPath': "/mnt/logs-{{ test_operator_job_name }}-step-" ~ index
'mountPath': "/mnt/logs-{{ test_operator_instance_name }}-step-" ~ index
}]
}}
volumes: >
Expand All @@ -115,7 +115,7 @@
apiVersion: v1
kind: Pod
metadata:
name: "test-operator-logs-pod-{{ run_test_fw }}-{{ test_operator_job_name }}"
name: "test-operator-logs-pod-{{ run_test_fw }}-{{ test_operator_instance_name }}"
namespace: "{{ cifmw_test_operator_namespace }}"
spec:
containers:
Expand All @@ -134,7 +134,7 @@
context: "{{ cifmw_openshift_context | default(omit) }}"
namespace: "{{ cifmw_test_operator_namespace }}"
kind: Pod
name: "test-operator-logs-pod-{{ run_test_fw }}-{{ test_operator_job_name }}"
name: "test-operator-logs-pod-{{ run_test_fw }}-{{ test_operator_instance_name }}"
wait: true
register: logs_pod
until: logs_pod.resources[0].status.phase == "Running"
Expand All @@ -146,10 +146,10 @@
KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
PATH: "{{ cifmw_path }}"
vars:
pod_path: mnt/logs-{{ test_operator_job_name }}-step-{{ index }}
pod_path: mnt/logs-{{ test_operator_instance_name }}-step-{{ index }}
ansible.builtin.shell: >
oc cp -n {{ cifmw_test_operator_namespace }}
openstack/test-operator-logs-pod-{{ run_test_fw }}-{{ test_operator_job_name }}:{{ pod_path }}
openstack/test-operator-logs-pod-{{ run_test_fw }}-{{ test_operator_instance_name }}:{{ pod_path }}
{{ cifmw_test_operator_artifacts_basedir }}
loop: "{{ logsPVCs.resources }}"
loop_control:
Expand All @@ -174,7 +174,7 @@
namespace: "{{ cifmw_test_operator_namespace }}"
kind: Pod
label_selectors:
- "instanceName={{ test_operator_job_name }}"
- "instanceName={{ test_operator_instance_name }}"
when: not cifmw_test_operator_dry_run | bool

- name: Get status from test pods
Expand Down Expand Up @@ -225,7 +225,7 @@
kind: "{{ test_operator_kind_name }}"
state: absent
api_version: test.openstack.org/v1beta1
name: "{{ test_operator_job_name }}"
name: "{{ test_operator_instance_name }}"
namespace: "{{ cifmw_test_operator_namespace }}"
wait: true
wait_timeout: 600
Expand All @@ -251,7 +251,7 @@
kind: Pod
state: absent
api_version: v1
name: "test-operator-logs-pod-{{ run_test_fw }}-{{ test_operator_job_name }}"
name: "test-operator-logs-pod-{{ run_test_fw }}-{{ test_operator_instance_name }}"
namespace: "{{ cifmw_test_operator_namespace }}"
wait: true
wait_timeout: 600
Expand Down
2 changes: 1 addition & 1 deletion roles/test_operator/tasks/runners/ansibletest_runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
vars:
run_test_fw: ansibletest
test_operator_config: "{{ stage_vars_dict.cifmw_test_operator_ansibletest_config }}"
test_operator_job_name: "{{ stage_vars_dict.cifmw_test_operator_ansibletest_name }}-{{ _stage_vars.name }}"
test_operator_instance_name: "{{ stage_vars_dict.cifmw_test_operator_ansibletest_name }}-{{ _stage_vars.name }}"
test_operator_kind_name: "{{ stage_vars_dict.cifmw_test_operator_ansibletest_kind_name }}"
test_operator_crd_name: "{{ stage_vars_dict.cifmw_test_operator_ansibletest_crd_name }}"
test_operator_workflow: "{{ stage_vars_dict.cifmw_test_operator_ansibletest_workflow }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/test_operator/tasks/runners/horizontest_runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
vars:
run_test_fw: horizontest
test_operator_config: "{{ stage_vars_dict.cifmw_test_operator_horizontest_config }}"
test_operator_job_name: "{{ stage_vars_dict.cifmw_test_operator_horizontest_name }}-{{ _stage_vars.name }}"
test_operator_instance_name: "{{ stage_vars_dict.cifmw_test_operator_horizontest_name }}-{{ _stage_vars.name }}"
test_operator_kind_name: "{{ stage_vars_dict.cifmw_test_operator_horizontest_kind_name }}"
test_operator_crd_name: "{{ stage_vars_dict.cifmw_test_operator_horizontest_crd_name }}"
test_operator_workflow: []
Expand Down
2 changes: 1 addition & 1 deletion roles/test_operator/tasks/runners/tempest_runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
vars:
run_test_fw: tempest
test_operator_config: "{{ stage_vars_dict.cifmw_test_operator_tempest_config }}"
test_operator_job_name: "{{ stage_vars_dict.cifmw_test_operator_tempest_name }}-{{ _stage_vars.name }}"
test_operator_instance_name: "{{ stage_vars_dict.cifmw_test_operator_tempest_name }}-{{ _stage_vars.name }}"
test_operator_kind_name: "{{ stage_vars_dict.cifmw_test_operator_tempest_kind_name }}"
test_operator_crd_name: "{{ stage_vars_dict.cifmw_test_operator_tempest_crd_name }}"
test_operator_workflow: "{{ stage_vars_dict.cifmw_test_operator_tempest_workflow }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/test_operator/tasks/runners/tobiko_runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
vars:
run_test_fw: tobiko
test_operator_config: "{{ stage_vars_dict.cifmw_test_operator_tobiko_config }}"
test_operator_job_name: "{{ stage_vars_dict.cifmw_test_operator_tobiko_name }}-{{ _stage_vars.name }}"
test_operator_instance_name: "{{ stage_vars_dict.cifmw_test_operator_tobiko_name }}-{{ _stage_vars.name }}"
test_operator_kind_name: "{{ stage_vars_dict.cifmw_test_operator_tobiko_kind_name }}"
test_operator_crd_name: "{{ stage_vars_dict.cifmw_test_operator_tobiko_crd_name }}"
test_operator_workflow: "{{ stage_vars_dict.cifmw_test_operator_tobiko_workflow }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/test_operator/tasks/tempest-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
tempest_list_allowed:
yaml_file: "{{ cifmw_test_operator_artifacts_basedir }}/list_allowed.yml"
groups: "{{ cifmw_test_operator_default_groups }}"
job: "{{ cifmw_test_operator_job_name | default(omit) }}"
job: "{{ cifmw_test_operator_instance_name | default(omit) }}"
register:
list_allowed

Expand Down

0 comments on commit 46c954f

Please sign in to comment.