Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid broken macaroonbakery release #625

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

coreycb
Copy link

@coreycb coreycb commented Dec 8, 2023

macaroonbakery 1.3.3 has a broken protobuf dependency, add a requirement to avoid that specific release:
go-macaroon-bakery/py-macaroon-bakery#94

(cherry picked from commit 8be4948)

macaroonbakery 1.3.3 has a broken protobuf dependency, add a requirement
to avoid that specific release:
go-macaroon-bakery/py-macaroon-bakery#94

(cherry picked from commit 8be4948)
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (109d0f7) 89.15% compared to head (8e48693) 89.15%.

Additional details and impacted files
@@               Coverage Diff                @@
##           stable/antelope     #625   +/-   ##
================================================
  Coverage            89.15%   89.15%           
================================================
  Files                   44       44           
  Lines                 4677     4677           
================================================
  Hits                  4170     4170           
  Misses                 507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@freyes freyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a stable/bobcat backport.

Copy link
Member

@freyes freyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixing the build via updating the requirements.txt only, on that basis I'm merging with a single +2 to unblock the gate.

The fix for stable/bobcat was in the queue and I didn't notice it, it got merged by now.

@freyes freyes merged commit fd8a709 into openstack-charmers:stable/antelope Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants