[stable/20.03] Fix ci errors #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `enable_openstack` class variable was left behind when the property of the same name was added. Since then a check for this condition has been added and it consequently leads to an error in the pep8 check. Signed-off-by: Frode Nordahl <[email protected]> (cherry picked from commit 0cacfc1) (cherry picked from commit 61869ad)
(cherry picked from commit 2b303a4)
- new tox 4 link requires handling One may see the following error: pep8: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'http_proxy https_proxy INTERFACE_PATH' - in image 22.04 python 3.6 and 3.7 for dropped (cherry picked from commit 1e312c8) (cherry picked from commit ffe7588)
brianphaley
approved these changes
May 14, 2024
| @@ -12,7 +12,7 @@ setenv = VIRTUAL_ENV={envdir} | |||
| CHARM_LAYERS_DIR={toxinidir}/layers | |||
| CHARM_INTERFACES_DIR={toxinidir}/interfaces | |||
| JUJU_REPOSITORY={toxinidir}/build | |||
| passenv = http_proxy https_proxy INTERFACE_PATH | |||
| passenv = http_proxy,https_proxy,INTERFACE_PATH | |||
There was a problem hiding this comment.
nit: most openstack repos put these on separate lines like setenv above, but if this is a backport we can leave it alone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports patches from stable/22.03 required to fix tox and pep8 errors