Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/22.03] config/description: Drop experimental status for hardware offload #85

Conversation

fnordahl
Copy link
Contributor

With the components listed in the charm-guide networking /ovn / hwol page [0], this feature is no longer considered to be experimental.

Fix up the wording around requirement for reboot to apply configuration.

Remove mention of the now deprecated sriov-netplan-shim service.

0: https://docs.openstack.org/charm-guide/latest/admin/networking/ovn/hardware-offload.html (cherry picked from commit 0597e4e)

@fnordahl fnordahl requested a review from mkalcok October 16, 2023 06:13
@fnordahl fnordahl changed the title config/description: Drop experimental status for hardware offload [stable/22.03] config/description: Drop experimental status for hardware offload Oct 16, 2023
@fnordahl fnordahl force-pushed the stable/22.03-update-hwol-description branch 4 times, most recently from 0255d1d to f726490 Compare October 16, 2023 06:25
mastier and others added 4 commits October 16, 2023 08:30
- new tox 4 link requires handling
One may see the following error:
pep8: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'http_proxy https_proxy INTERFACE_PATH'
- in image 22.04 python 3.6 and 3.7 for dropped

(cherry picked from commit 1e312c8)
The `enable_openstack` class variable was left behind when the
property of the same name was added.

Since then a check for this condition has been added and it
consequently leads to an error in the pep8 check.

Signed-off-by: Frode Nordahl <[email protected]>
(cherry picked from commit 0cacfc1)
Let's avoid churn on the stable branch for changing definitions of
`ubuntu-latest`.

Drop test for deprecated Python versions.

Signed-off-by: Frode Nordahl <[email protected]>
With the components listed in the charm-guide networking /ovn /
hwol page [0], this feature is no longer considered to be
experimental.

Fix up the wording around requirement for reboot to apply
configuration.

Remove mention of the now deprecated `sriov-netplan-shim` service.

0: https://docs.openstack.org/charm-guide/latest/admin/networking/ovn/hardware-offload.html
(cherry picked from commit 0597e4e)
@fnordahl fnordahl force-pushed the stable/22.03-update-hwol-description branch from f726490 to fff7747 Compare October 16, 2023 06:31
Copy link
Contributor

@mkalcok mkalcok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements.

@fnordahl fnordahl merged commit d4b6985 into openstack-charmers:stable/22.03 Oct 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants