[Hot fix] App crash when form loaded in edit mode contains unanswered repeat group item #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3547 +/- ##
=======================================
Coverage 27.2% 27.2%
Complexity 756 756
=======================================
Files 278 278
Lines 14239 14239
Branches 2582 2582
=======================================
Hits 3883 3883
Misses 9818 9818
Partials 538 538
Flags with carried forward coverage won't be shown. Click here to find out more. |
ndegwamartin
approved these changes
Oct 11, 2024
ellykits
added a commit
that referenced
this pull request
Oct 14, 2024
* Add date service to rules engine facts map (#3519) * Add summary mode (#3500) Co-authored-by: Elly Kitoto <[email protected]> * Refactor PDF config properties in QuestionnaireConfig (#3498) * Refactor to use PdfConfig Initially using QuestionnaireConfig for simplicity. * Process multi QRs in HtmlPopulator * Add new tag to check if Questionnaire has been submitted * Remove subjectType since subjectReference is used * Fix test and spotless * Address review * spotless * Cleanup * spotless * Fix test --------- Co-authored-by: Elly Kitoto <[email protected]> * Fix error validation highlighting not working when submit button is clicked bug (#3525) * Change progress bar color to blue (#3428) * update in-progress color on the map view. (#3529) Signed-off-by: Lentumunai-Mark <[email protected]> * Add medication sort custom search param (#3534) * Add medication sort custom search param * Run spotlessApply * Fix failing time based test * Pld docs adjustment (#3540) * sync typo * correct heading title * update header definition for p2p * upgrade packages * Update Geowidget to only show the Set Location dialog if no Locations to sync by have been selected (#3526) * Don't show no results dialogue on map when locations selected on multiselect. Signed-off-by: Lentumunai-Mark <[email protected]> * Fix failing tests. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> * Add Exit Dialog (#3487) * Add exit dialog * Fix a typo * Show Dialog only when Map or Register is visible * PR feedback changes * Fix failing check * Remove incorrect test * Refactor dialog condition logic --------- Co-authored-by: Benjamin Mwalimu <[email protected]> * Refactor working with bitmap images Signed-off-by: Elly Kitoto <[email protected]> * Add the EUSM Burundi flavour and Rename the existing EUSM flavour (#3548) * - Add the EUSM Burundi flavour - Rename the exisiting EUSM flavour * - Update the app naming * - update the flavour naming * Configure submit anyway button (#3535) * Update the Burundi EUSM flavor (#3553) * - Add the EUSM Burundi flavour - Rename the exisiting EUSM flavour * - Update the app naming * - update the flavour naming * - Update the flavor naming - Update the documentation * - Update the flavors section of the documentation to clarify on the naming convention * Bum p up data capture version (#3547) * Map search bug fixes (#3516) * - Updating the infinite scroll paging - Updating the behaviour after clearing search bar on the maps * - spotless apply * - Fix breaking tests on geo widget module * - Fix tests * - Run spotless * - Import `LazyPagingItems` * - Adding tests * - Update the APK naming * Ignore test to be refactored later Signed-off-by: Elly Kitoto <[email protected]> * - Run spotless * Update kujaku version. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]> * Fix loading related resources Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Rkareko <[email protected]> Co-authored-by: FikriMilano <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Peter Lubell-Doughtie <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]>
ellykits
added a commit
that referenced
this pull request
Oct 18, 2024
* Include listRepositoryResourceDataMap to nested list widgets Signed-off-by: Elly Kitoto <[email protected]> * Fix loading related resources data for List widget Signed-off-by: Elly Kitoto <[email protected]> * Refactor loading bitmap images (#3546) * Add date service to rules engine facts map (#3519) * Add summary mode (#3500) Co-authored-by: Elly Kitoto <[email protected]> * Refactor PDF config properties in QuestionnaireConfig (#3498) * Refactor to use PdfConfig Initially using QuestionnaireConfig for simplicity. * Process multi QRs in HtmlPopulator * Add new tag to check if Questionnaire has been submitted * Remove subjectType since subjectReference is used * Fix test and spotless * Address review * spotless * Cleanup * spotless * Fix test --------- Co-authored-by: Elly Kitoto <[email protected]> * Fix error validation highlighting not working when submit button is clicked bug (#3525) * Change progress bar color to blue (#3428) * update in-progress color on the map view. (#3529) Signed-off-by: Lentumunai-Mark <[email protected]> * Add medication sort custom search param (#3534) * Add medication sort custom search param * Run spotlessApply * Fix failing time based test * Pld docs adjustment (#3540) * sync typo * correct heading title * update header definition for p2p * upgrade packages * Update Geowidget to only show the Set Location dialog if no Locations to sync by have been selected (#3526) * Don't show no results dialogue on map when locations selected on multiselect. Signed-off-by: Lentumunai-Mark <[email protected]> * Fix failing tests. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> * Add Exit Dialog (#3487) * Add exit dialog * Fix a typo * Show Dialog only when Map or Register is visible * PR feedback changes * Fix failing check * Remove incorrect test * Refactor dialog condition logic --------- Co-authored-by: Benjamin Mwalimu <[email protected]> * Refactor working with bitmap images Signed-off-by: Elly Kitoto <[email protected]> * Add the EUSM Burundi flavour and Rename the existing EUSM flavour (#3548) * - Add the EUSM Burundi flavour - Rename the exisiting EUSM flavour * - Update the app naming * - update the flavour naming * Configure submit anyway button (#3535) * Update the Burundi EUSM flavor (#3553) * - Add the EUSM Burundi flavour - Rename the exisiting EUSM flavour * - Update the app naming * - update the flavour naming * - Update the flavor naming - Update the documentation * - Update the flavors section of the documentation to clarify on the naming convention * Bum p up data capture version (#3547) * Map search bug fixes (#3516) * - Updating the infinite scroll paging - Updating the behaviour after clearing search bar on the maps * - spotless apply * - Fix breaking tests on geo widget module * - Fix tests * - Run spotless * - Import `LazyPagingItems` * - Adding tests * - Update the APK naming * Ignore test to be refactored later Signed-off-by: Elly Kitoto <[email protected]> * - Run spotless * Update kujaku version. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]> * Fix loading related resources Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Rkareko <[email protected]> Co-authored-by: FikriMilano <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Peter Lubell-Doughtie <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]> * Fix failing UI tests Signed-off-by: Elly Kitoto <[email protected]> * Interpolate conditionalFhirPathExpressions in listResource (#3538) To pass in evaluated rule variables Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> * Fix apply stack tint. Signed-off-by: Lentumunai-Mark <[email protected]> * Apply opacity on view properties. (#3564) Signed-off-by: Lentumunai-Mark <[email protected]> * Fix duplication of List view item Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: Rkareko <[email protected]> Co-authored-by: FikriMilano <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Peter Lubell-Doughtie <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]> Co-authored-by: L≡ZRS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Hot fix for #3542
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile