Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor docs updates for DICOM and test driver #54

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Minor docs updates for DICOM and test driver #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88a0c20
Revert "docs/testsuite: document `dicom` feature flag"
bgilbert Sep 29, 2023
7b5d9e3
docs/testsuite: document new support for copying test case files
bgilbert Oct 3, 2023
f3c52d0
formats/dicom: link to libdicom GitHub page instead of docs
bgilbert Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions docs/testsuite/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ original slide (e.g., if OpenSlide falls back to `generic-tiff`), change
`vendor` to the new string or `null` for NULL.

If the test should only be run if particular OpenSlide dependencies are
available, set `requires` to a list of feature flags. Currently the only
defined feature flag is `dicom`.
available, set `requires` to a list of feature flags. Currently there are
no defined feature flags.

Pack the test:

Expand Down Expand Up @@ -209,6 +209,11 @@ generate:
? "CMU-1-40x - 2010-01-12 13.24.05(1,1).jpg"
: "jpegtran -restart 256B -outfile %(out)s %(in)s"

# Copy test case files during unpack.
copy:
? DCM_0_copy.dcm
: DCM_0.dcm

# Rename or move test case files during unpack.
rename:
? "CMU-1-40x - 2010-01-12 13.24.05(1,1).jpg"
Expand Down
4 changes: 2 additions & 2 deletions formats/dicom/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ OpenSlide will detect a file as DICOM if:

## File Organization

OpenSlide uses [libdicom](https://libdicom.readthedocs.io/) to parse and
load DICOM files.
OpenSlide uses [libdicom](https://github.com/ImagingDataCommons/libdicom/)
to parse and load DICOM files.

OpenSlide non-recursively scans the containing directory for other DICOM
files with the same _Series Instance UID_ attribute value as the specified
Expand Down