workflows: update to artifacts v4 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: c18933e ("Redo versioning scheme") Signed-off-by: Benjamin Gilbert <[email protected]>
Minor cleanup. Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
It's no longer possible for multiple jobs to accumulate results into the same artifact. Upload separate artifacts for the sdist and bdist archives, and have the release job download both via wildcard. Unlike OpenSlide Python, which still needs the artifact Zips to have a containing directory name with build information, openslide-bin includes build information in archive names. Drop the containing directory from the artifact Zips in favor of directly wrapping the enclosed archives. Continue using job output variables to pass artifact details within the workflow. However, since there's no longer a single artifact name or directory, workflow-level outputs would need separate variables for each artifact. Instead, drop the `artifact` output var, and require callers to use wildcards as needed. The sdist/bdist archives are already compressed, so disable compression in their wrapper Zips. Signed-off-by: Benjamin Gilbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no longer possible for multiple jobs to accumulate results into the same artifact. Upload separate artifacts for the sdist and bdist archives, and have the release job download both via wildcard.
Unlike OpenSlide Python, which still needs the artifact Zips to have a containing directory name with build information, openslide-bin includes build information in archive names. Drop the containing directory from the artifact Zips in favor of directly wrapping the enclosed archives.
Continue using job output variables to pass artifact details within the workflow. However, since there's no longer a single artifact name or directory, workflow-level outputs would need separate variables for each artifact. Instead, drop the
artifactoutput var, and require callers to use wildcards as needed.The sdist/bdist archives are already compressed, so disable compression in their wrapper Zips.