Remove pass-through Meson options #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openslide-bin project doesn't directly use openslide_werror or version_suffix; it just passes them to some subprojects as default_options. However, these are _defaults_: they take effect during initial configuration, but if later changed with `meson setup --reconfigure` or `meson configure`, the new values aren't re-propagated to the subprojects. The abstraction thus encourages errors, and it doesn't really add much value in the first place. Remove the top-level options and replace them with documentation about setting the corresponding subproject options directly. Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
openslide-binproject doesn't directly useopenslide_werrororversion_suffix; it just passes them to some subprojects asdefault_options. However, these are defaults: they take effect during initial configuration, but if later changed withmeson setup --reconfigureormeson configure, the new values aren't re-propagated to the subprojects. The abstraction thus encourages errors, and it doesn't really add much value in the first place. Remove the top-level options and replace them with documentation about setting the corresponding subproject options directly.