Handle buildtype, wrap_mode, and OpenSlide werror in meson.build
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always want plain and nofallback, respectively. Set them in meson.build so manual Meson invocations don't need to do it. Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
bgilbert
changed the title
buildtype and wrap_mode in meson.buildbuildtype, wrap_mode, and OpenSlide werror in meson.build
Don't require build.sh or manual Meson builds to know how to pass werror options directly to the OpenSlide and OpenSlide Java subprojects. Signed-off-by: Benjamin Gilbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always want
buildtype=plainandwrap_mode=nofallback. Set them inmeson.buildso manual Meson invocations don't need to do it. Also, add anopenslide_werrorMeson option sobuild.shor manual Meson builds don't need to know how to passwerroroptions directly to the OpenSlide and OpenSlide Java subprojects.