Add cross files for macOS build #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Gilbert <[email protected]>
Prep for later commit. The build order is an implementation detail, so allow it to diverge from the declaration order in build.sh. The latter is used when building the version table. Signed-off-by: Benjamin Gilbert <[email protected]>
Prevent macOS builds in GitHub Actions from picking up libintl from Homebrew. Signed-off-by: Benjamin Gilbert <[email protected]>
gettext() is part of glibc. Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
and update the Direct workflow to exercise it. Build for both x86_64 and arm64 (as macOS calls them) and merge the builds into universal binaries. Configure the slidetool binary to load libopenslide.1.dylib from the same directory. Create separate debuginfo. Target macOS 11 and above, since those are the releases that aren't EOL. Use ld export filtering to export only OpenSlide's public symbols; it's safe to configure this globally because the build only produces one dylib. Compiler hardening flags don't appear to be well-documented on macOS, but -fstack-protector-strong appears reasonable. Use it. Use zlib, libffi, libxml2, and SQLite from the macOS SDK, rather than shipping our own copies. macOS also ships PCRE2, but its headers aren't included in the SDK, so don't use it. Signed-off-by: Benjamin Gilbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Direct workflow to exercise it. Build for both
x86_64andarm64(as macOS calls them) and merge the builds into universal binaries. Configure theslidetoolbinary to loadlibopenslide.1.dylibfrom the same directory. Create separate debuginfo.Target macOS 11 and above, since those are the releases that aren't EOL. Use
ldexport filtering to export only OpenSlide's public symbols; it's safe to configure this globally because the build only produces one dylib.Compiler hardening flags don't appear to be well-documented on macOS, but
-fstack-protector-strongappears reasonable. Use it.Use zlib, libffi, libxml2, and SQLite from the macOS SDK, rather than shipping our own copies. macOS also ships PCRE2, but its headers aren't included in the SDK, so don't use it.