Unit tests for query_initialized #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkerha1
force-pushed
the
query_initialized
branch
from
52e55f8 to
7665287
Compare
parkerha1
force-pushed
the
query_initialized
branch
from
7665287 to
949c4a2
Compare
davidozog
reviewed
Sep 25, 2024
davidozog
reviewed
Sep 26, 2024
parkerha1
force-pushed
the
query_initialized
branch
from
1a2744e to
6e13f1c
Compare
davidozog
reviewed
Sep 27, 2024
| int finalizes_done = 0; | ||
|
|
||
| // Check if SHMEM is initialized before calling init | ||
| shmem_query_initialized(&initialized); |
There was a problem hiding this comment.
I believe this should probably be shmemx_query_initialized... At least for tests-sos v1.5.x.
If we go that route, then this test wouldn't build against your SOS implementation of course, but I think that's ok temporarily during our transition to v1.6.x.
I think let's keep the test this way (shmem_) until we are ready to merge Sandia-OpenSHMEM/SOS#1144. Then we can test against this? Although, I'm not certain our CI covers shmemx very well... will have to check.
Sorry for the confusion...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.