-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for IBPUT/IBGET #35
Add tests for IBPUT/IBGET #35
Conversation
@wrrobin It may be good to add Bryan, Mark, and Parker as contributors to this repo as well |
@philipmarshall21 - This looks good. One comment is that when we move these interfaces to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Please take care of the minor comments.
0db6fd0
to
ebbaf85
Compare
Yep, totally agree! |
Recommended changes have been applied. Not sure that I should merge just yet. The SOS CI would fail when trying to build the new tests because the function declarations are not present in shmemx.h (except in the SOS PR that adds ibput/ibget implementation). May be best to wait until SOS PR 1114 is reviewed and ready to be merged. Then we could merge this PR, run the CI on PR 1114 once more and merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests do not cover the API well because dest stride, source stride, block size, and num blocks are all constant/trivial. I think we can pretty easily add basic checks here, but it's ok to punt on it for now.
This PR adds tests for the IBPUT/IBGET APIs (currently shmemx extensions, but ratified and to be included in a later OpenSHMEM spec version).