BASE: added test of basic operations for malloc_with_hint #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Oblomov <[email protected]>
hoopoepg
force-pushed
the
topic/malloc-with-hint-basic-ops
branch
from
ef37478 to
77f7de7
Compare
yosefe
reviewed
May 23, 2019
|
|
||
| shmem_free(p2); | ||
| #endif /* HAVE_DECL_SHMEMX_MALLOC_WITH_HINT */ | ||
| return TC_PASS; |
There was a problem hiding this comment.
is there something like TC_SKIP?
There was a problem hiding this comment.
there is, but it is used in aggregate test state (higher level). here is no way to set personal test result.
I updated logging of tests to print more accurate results, also added warning message on missing API
| shmem_free(p2); | ||
|
|
||
| /* corner cases */ | ||
| p2 = shmem_realloc(p1, 0); /* works as shfree() */ |
There was a problem hiding this comment.
shall we also check realloc(NULL)?
There was a problem hiding this comment.
realloc(NULL) is tested in another case (
tests-mellanox/verifier/basic/osh_basic_tc3.c
Line 405 in e1d39bb
mike-dubman
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Oblomov [email protected]