[SHMEM 1.6 Sec 9.10] Collectives section committee changes #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo Co-authored-by: David Ozog <[email protected]>
White Space Co-authored-by: David Ozog <[email protected]>
Typo, uppercase
Co-authored-by: David Ozog <[email protected]>
typo Co-authored-by: Muhammad Awad <[email protected]>
[Collectives] Deprecate active based language
collectives: remove unnecessary new line
scan: 488 section committee edits (nelems/overlap)
collectives: clarify src buffer entry requirements
jdinan
reviewed
Sep 5, 2024
Merged
jdinan
changed the title
davidozog
commented
Sep 27, 2024
| \item For active-set-based routines, | ||
| the values in the \VAR{pSync} array are restored to the original values. | ||
| \item Its \VAR{dest} symmetric data object is completely updated and the | ||
| data has been copied out of the source data object. |
There was a problem hiding this comment.
Suggested change
| data has been copied out of the source data object. | |
| data has been copied out of the \VAR{source} data object. |
davidozog
commented
Sep 27, 2024
| must participate in the operation. | ||
| \item Only \acp{PE} in the active set may call the routine. If a | ||
| \ac{PE} not in the active set calls an active-set-based | ||
| \item The \VAR{dest} object is updated on all PEs other than the root PE. |
There was a problem hiding this comment.
Suggested change
| \item The \VAR{dest} object is updated on all PEs other than the root PE. | |
| \item The \VAR{dest} object is updated on all \acp{PE} other than the root PE. |
davidozog
commented
Sep 27, 2024
| @@ -66,15 +66,13 @@ | |||
| \openshmem \FUNC{collect} and \FUNC{fcollect} routines perform a collective | |||
| operation to concatenate \VAR{nelems} | |||
| data items from the \source{} array into the | |||
| \dest{} array, over an \openshmem team or active set | |||
| in processor number order. The resultant \dest{} array contains the contribution from | |||
| \dest{} array, over an \openshmem team in processor number order. | |||
There was a problem hiding this comment.
Suggested change
| \dest{} array, over an \openshmem team in processor number order. | |
| \dest{} array, over an \openshmem team in \ac{PE} number order. |
davidozog
commented
Sep 27, 2024
| @@ -1,7 +1,11 @@ | |||
| \apisummary{ | |||
| Registers the arrival of a \ac{PE} at a synchronization point. | |||
| This routine does not return until all other \acp{PE} in a given OpenSHMEM team | |||
| or active set arrive at this synchronization point. | |||
| arrive at this synchronization point. | |||
There was a problem hiding this comment.
Suggested change
| arrive at this synchronization point. | |
| arrives at this synchronization point. |
|
@jdinan - this PR can be closed, correct? I double checked all the section changes into RC1 and edits from the reading are accounted for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This includes these PRs:
davidozog#11
davidozog#10
davidozog#9
davidozog#8
Any corresponding changelog entries are in the backmatter section.
This PR about reduction associativity is not included and will likely will not make it for RC1:
davidozog#12
Proposal Checklist