Add extension for 64k pages on aarch64 #1351
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @jbtrystram. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
Let's link to the COS epic (https://issues.redhat.com/browse/COS-2402) in the title and commit instead of the OCPSTRAT card. |
jbtrystram
force-pushed
the
arm-64pages
branch
2 times, most recently
from
05ae81e to
e5175d1
Compare
|
Can you update the first comment here as well? It's not updated when you push new commits unfortunately :/. |
|
For Don't we have them as well for |
|
Looks like we do:
|
|
We'll need something like coreos/rpm-ostree#4386 as well for rpm-ostree |
Thanks for the pointers ! I am updating this. |
jbtrystram
force-pushed
the
arm-64pages
branch
from
e5175d1 to
cb976c9
Compare
extensions-c9s.yaml
Outdated
| - kernel-64k-core | ||
| - kernel-64k-modules | ||
| - kernel-64k-modules-core | ||
| - kernel-64k-modules-extra |
There was a problem hiding this comment.
Nit: You need an empty line at the end of a file. Make sure to configure your editor to do it for you. In some editors, this empty line is not shown, in some it is.
jbtrystram
force-pushed
the
arm-64pages
branch
2 times, most recently
from
52e8eaf to
e82bf76
Compare
jbtrystram
force-pushed
the
arm-64pages
branch
from
e82bf76 to
a6df82e
Compare
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
Ugh. Yes. And we'll need to get that into 4.14. |
Like the others. cc openshift/os#1351 (comment)
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jbtrystram, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jbtrystram: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Since RHEL 9 reverted to 4K memory pages for aarch64, add a way to switch to a hugepage kernel. The MachineConfig should contain the following to trigger the kernel switch: spec: kernelType: 64k-pages This is exclusive with the `realtime` kernel option. xref https://issues.redhat.com/browse/COS-2402 This requires openshift/os#1351 Signed-off-by: jbtrystram <[email protected]>
Since RHEL 9 reverted to 4K memory pages for aarch64, add a way to switch to a hugepage kernel. The MachineConfig should contain the following to trigger the kernel switch: spec: kernelType: 64k-pages This is exclusive with the `realtime` kernel option. xref https://issues.redhat.com/browse/COS-2402 This requires openshift/os#1351 Signed-off-by: jbtrystram <[email protected]>
Since RHEL 9 reverted to 4K memory pages for aarch64, add a way to switch to a hugepage kernel. The MachineConfig should contain the following to trigger the kernel switch: spec: kernelType: 64k-pages This is exclusive with the `realtime` kernel option. xref https://issues.redhat.com/browse/COS-2402 This requires openshift/os#1351 Signed-off-by: jbtrystram <[email protected]>
xref https://issues.redhat.com/browse/COS-2402