Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-44861: Use Client Certificate Authentication for ARO HCP deployments #1169

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-44861: Use Client Certificate Authentication for ARO HCP deployments #1169

wants to merge 1 commit into from

Conversation

bryan-cox
Copy link
Member

Manual backport of #1151

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 25, 2024
@openshift-ci-robot
Copy link
Contributor

@bryan-cox: This pull request references Jira Issue OCPBUGS-44861, which is invalid:

  • expected dependent Jira Issue OCPBUGS-44627 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual backport of #1151

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox changed the title OCPBUGS-44861: Use Client Certificate Authentication for ARO HCP deployments [release-4.17] OCPBUGS-44861: Use Client Certificate Authentication for ARO HCP deployments Nov 25, 2024
@openshift-ci openshift-ci bot requested review from miheer and rfredette November 25, 2024 18:24
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frobware for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@candita
Copy link
Contributor

candita commented Dec 11, 2024

@bryan-cox if this is a draft, can you please mark it as such? If not, can you fix the commits?

@bryan-cox
Copy link
Member Author

@candita -Yes, sorry! I'm not sure how that got in there.

@bryan-cox
Use Client Cert Auth for ARO HCP deployments
e8118a8 
Use Client Certificate Authentication for ARO HCP deployments.
HyperShift will pass the needed environment variables for this
authentication method: ARO_HCP_MI_CLIENT_ID, ARO_HCP_TENANT_ID, and
ARO_HCP_CLIENT_CERTIFICATE_PATH.

Signed-off-by: Bryan Cox <[email protected]>
@bryan-cox
Copy link
Member Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Miciah
Copy link
Contributor

Miciah commented Dec 18, 2024

/assign

@candita
Copy link
Contributor

candita commented Dec 18, 2024

/assign @gcs278

gcs278
gcs278 reviewed Dec 19, 2024
View reviewed changes
pkg/dns/azure/client/auth.go
@@ -70,17 +76,43 @@ func getAuthorizerForResource(config Config) (autorest.Authorizer, error) {
}

var cred azcore.TokenCredential
// MSI Override for ARO HCP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also cherry-pick #1144 before you cherry-pick #1151 as well to avoid this merge conflict and also for maintaining the Git commit history?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcs278 gcs278 gcs278 left review comments

@miheer miheer Awaiting requested review from miheer

@rfredette rfredette Awaiting requested review from rfredette

Assignees

@Miciah Miciah

@gcs278 gcs278

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bryan-cox @openshift-ci-robot @candita @Miciah @gcs278