Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-43377: Allow controller to continue when assisted-service #934

Open
wants to merge 1 commit into
base: release-4.16
Choose a base branch
from
Open

[release-4.16] OCPBUGS-43377: Allow controller to continue when assisted-service #934

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #918

/assign rwsu

@rwsu
OCPBUGS-38466: Allow controller to continue when assisted-service
ead4de5 
is unavailable in agent-based installs.

assisted-service runs on the bootstrap node in agent-based
installs. The bootstrap node reboots after the control plane
is available.

If the assisted-installer-controller restarts after the
bootstrap node reboots, or for some reason the controller
is never able to contact assisted-service, the controller loops
waiting or assisted-service to become available, times out, and
exits.

With compact clusters, because the controller exited and is unable
to approve CSRs, the third control plane node is unable to join the
cluster causing the cluster installation to fail.

If the invoker is agent-installer, instead of exiting, this patch
allows the controller to continue to run when assisted-service is
offline.

Because assisted-service may be unavailable,
HasValidvSphereCredentials has been updated to also look at
the install-config to determine if credentials were set. Because
username and password are redacted, only the server name is used
to determine if valid credentials were provided.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 15, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42839 has been cloned as Jira Issue OCPBUGS-43377. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-43377: Allow controller to continue when assisted-service

In response to this:

This is an automated cherry-pick of #918

/assign rwsu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-42839: Allow controller to continue when assisted-service [release-4.16] OCPBUGS-43377: Allow controller to continue when assisted-service Oct 15, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 15, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43377, which is invalid:

  • expected dependent Jira Issue OCPBUGS-42839 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #918

/assign rwsu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign rccrdpccl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 15, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rwsu
Copy link
Contributor

rwsu commented Oct 17, 2024

/jira refresh
Can be closed, was resolved in #914

@openshift-ci-robot
Copy link

@rwsu: This pull request references Jira Issue OCPBUGS-43377, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh
Can be closed, was resolved in #914

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ori-amizur ori-amizur Awaiting requested review from ori-amizur

@romfreiman romfreiman Awaiting requested review from romfreiman

Assignees

@rwsu rwsu

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @rwsu