Adding self taint toleration for wasp-agent deployment #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taint logic needs to be synced with the operator that generates the wasp-agent ds manifest, because wasp-agent needs to tolerate its own taint. this is needed in case wasp-agent pod will be restarted while the node is tainted. wasp-agent needs to complete its eviction operation and remove the taint when resources are back to normal. Signed-off-by: Igor Bezukh <[email protected]>
added self taint toleration to the wasp-agent ds yaml. Signed-off-by: Igor Bezukh <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@enp0s3 We need a follow up PR for the docs edit: never-mind i just realized that we refer users to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Bezukh [email protected]
When node is under pressure and we evict pods, we also taint the node. If for some reason wasp-agent would be restarted, the wasp-agent pod won't be able to run on a tainted node.
This is bad since wasp-agent needs to complete the eviction process, and clear the taint as far as node resources are stable again.