rank_utils: ignore pod containers whose cadviosr stats are not ready yet

there might be a situation where pod ranking is done on a freshly created pod whose containers stats are not yet ready in cadvisor. Signed-off-by: Igor Bezukh <[email protected]>
openshift-virtualization · Nov 21, 2024 · 31791ca · 31791ca
1 parent 7dc3122
commit 31791ca
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/pkg/wasp/pod-ranker/rank_utils.go b/pkg/wasp/pod-ranker/rank_utils.go
@@ -134,7 +134,12 @@ func exceedMemoryLimits(summary summaryFunc) cmpFunc {
 func hasContainerExceedMemoryLimits(pod *v1.Pod, summary stats_collector.PodSummary) bool {
 	for _, container := range pod.Spec.Containers {
 		if rQuantity, ok := container.Resources.Limits[v1.ResourceMemory]; ok {
-			memoryAndSwapSumQuantity := memoryAndSwapUsage(*summary.Containers[container.Name].MemoryWorkingSetBytes, *summary.Containers[container.Name].MemorySwapCurrentBytes)
+			containerStats, exists := summary.Containers[container.Name]
+			if !exists {
+				continue
+			}
+			memoryAndSwapSumQuantity :=
+				memoryAndSwapUsage(*containerStats.MemoryWorkingSetBytes, *containerStats.MemorySwapCurrentBytes)
 			if memoryAndSwapSumQuantity.Cmp(rQuantity) == 1 {
 				return true
 			}
@@ -143,7 +148,12 @@ func hasContainerExceedMemoryLimits(pod *v1.Pod, summary stats_collector.PodSumm
 
 	for _, container := range pod.Spec.InitContainers {
 		if rQuantity, ok := container.Resources.Limits[v1.ResourceMemory]; ok {
-			memoryAndSwapSumQuantity := memoryAndSwapUsage(*summary.Containers[container.Name].MemoryWorkingSetBytes, *summary.Containers[container.Name].MemorySwapCurrentBytes)
+			containerStats, exists := summary.Containers[container.Name]
+			if !exists {
+				continue
+			}
+			memoryAndSwapSumQuantity :=
+				memoryAndSwapUsage(*containerStats.MemoryWorkingSetBytes, *containerStats.MemorySwapCurrentBytes)
 			if memoryAndSwapSumQuantity.Cmp(rQuantity) == 1 {
 				return true
 			}