OCM-8256 | feat: add methods to attach policies #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OAharoni-RedHat Do you remove completeRolePolicyDocument function? |
|
@yingzhanredhat I'm not, as far as I can tell it's still required for how the formatting of the new |
|
/lgtm |
robpblake
reviewed
May 31, 2024
pkg/aws/aws_client/role.go
Outdated
| path string, | ||
| policyArn string) (types.Role, error) { | ||
| role, err := client.CreateRole(roleName, assumeRolePolicyDocument, permissionBoundry, tags, path) | ||
| if err != nil { |
There was a problem hiding this comment.
@OAharoni-RedHat Do you need to check the err before you try and call client.AttachPolicy? For example: what if err is a failure to create the role? We should return a clear error here if the role can not be created?
There was a problem hiding this comment.
Hey Rob, good catch, I miswrote this statement. I meant to only attempt to attach the policy if there's no error rather than only if there's an error! I think that should cover what you're suggesting here with clear error returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 new method: CreateRoleAndAttachPolicy
other added methods are migrated from openshift-rosa-cli: https://github.com/OAharoni-RedHat/openshift-rosa-cli/blob/master/pkg/aws_client/aws_v1/role.go