Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-15661: Include inform policies in configuration timeout calculation #320

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

Missxiaoguo
Copy link
Collaborator

For the ORAN use case, inform policies should only be used to validate cluster configurations. When all enforce and inform policies are compliant, the cluster configuration is considered complete, and provisioning can be fulfilled. Updated logic now includes inform policies in the configuration timeout calculation.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 19, 2024

@Missxiaoguo: This pull request references CNF-15661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

For the ORAN use case, inform policies should only be used to validate cluster configurations. When all enforce and inform policies are compliant, the cluster configuration is considered complete, and provisioning can be fulfilled. Updated logic now includes inform policies in the configuration timeout calculation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Missxiaoguo
Copy link
Collaborator Author

/hold
Try to finish e2e testing after fixing the hub cluster issue.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@Missxiaoguo
Copy link
Collaborator Author

/unhold
Tested e2e for both timeout and non-timeout cases.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@Missxiaoguo Missxiaoguo requested review from bartwensley, irinamihai and browsell and removed request for mlguerrero12 November 20, 2024 15:07
@browsell
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2024
@browsell
Copy link
Collaborator

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2024
Copy link

openshift-ci bot commented Nov 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d6395c8 into openshift-kni:main Nov 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants