Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call updateState when query is cancelled #3139

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Call updateState when query is cancelled #3139

merged 2 commits into from
Oct 30, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Oct 29, 2024 •
edited
Loading

Description

  • Call updateState when query is cancelled
    • This change is for async-query-core library consumer to update cancel status
    • This does not affect the async-query behavior since AsyncQueryJobMetadata record does not store status yet. ([FEATURE] Unify the async query request metadata model #3140 is an issue for unifying the model to single one, and we need to handle the update status within the fix)

Related Issues

#3140 (This PR does not solve this issue)

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224
Call updateState when query is cancelled
48b7af0 
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224
Fix code style
f593d04 
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224 ykmr1224 marked this pull request as ready for review October 30, 2024 18:22
@noCharger
Copy link
Collaborator

This does not affect the async-query behavior since AsyncQueryJobMetadata record does not store status yet

It makes me feel like this PR is a short term solution, is it an urgent change or we can go with longer term approach #3140?

@ykmr1224
Copy link
Collaborator Author

This does not affect the async-query behavior since AsyncQueryJobMetadata record does not store status yet

It makes me feel like this PR is a short term solution, is it an urgent change or we can go with longer term approach #3140?

Yes, this is short term, but it does not have side effect. #3140 require much more effort and we don't have bandwidth right now.

@ykmr1224 ykmr1224 merged commit 5716cab into opensearch-project:main Oct 30, 2024
14 of 15 checks passed
@ykmr1224 ykmr1224 added the maintenance Improves code quality, but not the product label Oct 31, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 31, 2024
@github-actions
Call updateState when query is cancelled (#3139)
b61876b 
* Call updateState when query is cancelled

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix code style

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit 5716cab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 31, 2024
Merged
ykmr1224 pushed a commit that referenced this pull request Oct 31, 2024
@opensearch-trigger-bot @github-actions
Call updateState when query is cancelled (#3139) (#3144)
c942259 
* Call updateState when query is cancelled



* Fix code style



---------


(cherry picked from commit 5716cab)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankao-az seankao-az seankao-az approved these changes

@noCharger noCharger noCharger approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

Assignees
No one assigned
Labels
backport 2.x maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykmr1224 @noCharger @seankao-az