Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Get well plan for the Github CI pipeline #3168

Open
1 of 4 tasks
andy-k-improving opened this issue Nov 26, 2024 · 10 comments · Fixed by #3177 · May be fixed by opensearch-project/observability#1886
Open
1 of 4 tasks

[FEATURE] Get well plan for the Github CI pipeline #3168

andy-k-improving opened this issue Nov 26, 2024 · 10 comments · Fixed by #3177 · May be fixed by opensearch-project/observability#1886
Labels
enhancement New feature or request

Comments

@andy-k-improving
Copy link
Contributor

andy-k-improving commented Nov 26, 2024

Is your feature request related to a problem?

At the moment, the CI build for the project is broken, and PR patch being merged regardless of the CI build result.
This brings additional risk to the project, because there may be additional failure that a particular patch introduced, but being ignored by both Dev and reviewer, due to the fact that build is always failing on the main branch.

What solution would you like?

Existing CI errors with corresponded fix:

  • Linux build : Fix: CI Github Action  #3177
  • Pages build and deployment (If Github is not in use, can skip)
  • BWC tests (Require Linux platform to test)
  • Code coverage

What alternatives have you considered?
N/A

Do you have any additional context?
image

image
@andy-k-improving andy-k-improving added enhancement New feature or request untriaged labels Nov 26, 2024
@YANG-DB
Copy link
Member

YANG-DB commented Nov 27, 2024

Thanks @andy-k-improving - it sounds like we have a plan !!

@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Nov 29, 2024

Seems to be related: actions/checkout#1590, actions/checkout#1809
Tracing the commit history to better understand since when we have this on main

@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Nov 29, 2024

The error seems to happen after 8b2d01e, but I don't think it's related to the code change itself, it's more about aciton/checkout@v3 looking for an old version of node which is not exist on the ci-runner.
image

@andy-k-improving
Copy link
Contributor Author

Similar fix applied on Job-scheduler and it's working.
I will create a PR to replicate the change tomorrow.
opensearch-project/job-scheduler#702

@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Nov 29, 2024

bwc seems to be broken also:
https://github.com/opensearch-project/sql/actions/runs/11621890097/job/32366453716

This will be the next item to fix.

@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Dec 2, 2024

@YANG-DB Can you re-open this, as bwc test need to be fixed also, also we should bring up the discussion of the code coverage, as it's 5% behind now compare to the required 99%.

@YANG-DB YANG-DB reopened this Dec 2, 2024
@YANG-DB YANG-DB removed the untriaged label Dec 2, 2024
@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Dec 2, 2024

I tried to reproduce the bwc-test locally on Mac, however the Gradle build script script looks for the opensearch-min artifact under: 'https://artifacts.opensearch.org/releases/core/opensearch/2.17.0/opensearch-min-2.17.0-darwin-x64.tar.gz'
Which I have checked on the OpenSearch site, and only Linux binary is published at the moment for min but not darwin and window.

@YANG-DB Wonder have you seen this issue before?


* What went wrong:
Execution failed for task ':integ-test:sqlBwcCluster#oldVersionClusterTask1'.
> Could not resolve all files for configuration ':integ-test:opensearch_distro_extracted_testclusters-integ-test-sqlBwcCluster1-0-2.17.0-'.
   > Could not resolve opensearch-distribution:opensearch:2.17.0.
     Required by:
         project :integ-test
      > Could not resolve opensearch-distribution:opensearch:2.17.0.
         > Could not get resource 'https://artifacts.opensearch.org/releases/core/opensearch/2.17.0/opensearch-min-2.17.0-darwin-x64.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/releases/core/opensearch/2.17.0/opensearch-min-2.17.0-darwin-x64.tar.gz'. Received status code 403 from server: Forbidden
      > Could not resolve opensearch-distribution:opensearch:2.17.0.
         > Could not get resource 'https://artifacts.opensearch.org/release-candidates/core/opensearch/2.17.0/opensearch-min-2.17.0-darwin-x64.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/release-candidates/core/opensearch/2.17.0/opensearch-min-2.17.0-darwin-x64.tar.gz'. Received status code 403 from server: Forbidden

@YANG-DB
Copy link
Member

YANG-DB commented Dec 2, 2024

I tried to reproduce the bwc-test locally on Mac, however the Gradle build script script looks for the opensearch-min artifact under: 'https://artifacts.opensearch.org/releases/core/opensearch/2.17.0/opensearch-min-2.17.0-darwin-x64.tar.gz' Which I have checked on the OpenSearch site, and only Linux binary is published at the moment for min but not darwin and window.

@YANG-DB Wonder have you seen this issue before?

Unfortunately no

@andy-k-improving
Copy link
Contributor Author

I tried to reproduce the bwc-test locally on Mac, however the Gradle build script script looks for the opensearch-min artifact under: 'https://artifacts.opensearch.org/releases/core/opensearch/2.17.0/opensearch-min-2.17.0-darwin-x64.tar.gz' Which I have checked on the OpenSearch site, and only Linux binary is published at the moment for min but not darwin and window.
@YANG-DB Wonder have you seen this issue before?

Unfortunately no

Thx for the quick reply.

If that is the case, I will put this on hold, as I don't a Linux || Ubuntu machine handy, and the amount of time to make the bwc task run on Mac is unceratin, because the build script to download the min artifact is located on the main OpenSearch repo.

@andy-k-improving
Copy link
Contributor Author

If others would be able to run bwc test locally, please free to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants