-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit service account permission #3607
Limit service account permission #3607
Conversation
src/main/java/org/opensearch/security/privileges/PrivilegesEvaluator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
e270d77
to
691b347
Compare
Signed-off-by: Ryan Liang <[email protected]>
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
1c8fafe
to
1dc296b
Compare
…tem indices and regular indices Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @RyanL1997. I've left some nits.
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/privileges/PrivilegesEvaluator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3607-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d10475cbf0cc8ccdf959964c5d30777ee72e7bcc
# Push it to GitHub
git push --set-upstream origin backport/backport-3607-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
…ject#3607) Signed-off-by: Ryan Liang <[email protected]>
Description
Limit service account permission
Enhancement
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.