Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.17] set custom rule doc id to the id passed in rule yaml instead of autogenerated name #1347

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Oct 8, 2024

Description
when custom rule is created we are not setting rule document id to the string passed in rule yaml in id field. we autogenerate the id
this change sets custom rule doc id to the id passed in rule yaml instead of autogenerated id

Related Issues
Resolves #1301

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
@eirsep eirsep merged commit 37e7abb into opensearch-project:2.17 Oct 9, 2024
13 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 15, 2024
…f autogenerated name (#1347)

* set custom rule doc id to the id passed in rule yaml instead of autogenerated name

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix test

Signed-off-by: Surya Sashank Nistala <[email protected]>

* handle generic Exception

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 37e7abb)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.15 2.15
# Navigate to the new working tree
cd .worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-1347-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37e7abb200d71ef76537969f6166f691c8ecfd9f
# Push it to GitHub
git push --set-upstream origin backport/backport-1347-to-2.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-1347-to-2.15.

AWSHurneyt pushed a commit that referenced this pull request Nov 20, 2024
…f autogenerated name (#1347) (#1419)

* set custom rule doc id to the id passed in rule yaml instead of autogenerated name

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix test

Signed-off-by: Surya Sashank Nistala <[email protected]>

* handle generic Exception

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 37e7abb)

Co-authored-by: Surya Sashank Nistala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants