-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve detection of Time-Zone inconsistencies #2456
base: main
Are you sure you want to change the base?
Commits on Mar 12, 2024
-
Improve detection of Time-Zone inconsistencies
We have a track record of Time-Zone inconsistencies in the events of the project website (e.g. opensearch-project#1616, opensearch-project#1805, opensearch-project#2288, opensearch-project#2418, opensearch-project#2422, opensearch-project#2431, opensearch-project#2449). In order to detect these inconsistencies earlier, make the `tz` mandatory and check that the Time-Zone offset match the Time-Zone name. These checks require a working bundle so run it on GitHub actions and keep the old pre-commit check to only check date formatting using basic UNIX tooling. Adjust the events templates to match what we expect. While here, also check that non-online events have the needed `location.city` and `location.country`. Signed-off-by: Romain Tartière <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9957015 - Browse repository at this point
Copy the full SHA 9957015View commit details
Commits on Mar 13, 2024
-
Add
tz
to all events without oneMost of these events have a Time-Zone offset of -0700 or -0800 which makes me think they are all using the America/Los_Angeles Time-Zone (sometimes with the wrong offset, which will be fixed in another commit). Updated with: ``` grep -r --files-without-match '^tz:' _events | xargs sed -i '' -E -e'/^online:/a\ tz: America/Los_Angeles' ``` Signed-off-by: Romain Tartière <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1d37616 - Browse repository at this point
Copy the full SHA 1d37616View commit details -
Fix daylight-saving offset errors of America/Los_Angeles events
These inconsistencies are now being reported, when -0700 and -0800 are used incorectly. Signed-off-by: Romain Tartière <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 919fbdb - Browse repository at this point
Copy the full SHA 919fbdbView commit details -
According to the meetup page, the event was on 24.01.2023 at 19:00 local time. The Time-Zone offset then correspond to Europe/Warsaw. Signed-off-by: Romain Tartière <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f81b0c8 - Browse repository at this point
Copy the full SHA f81b0c8View commit details -
The website says it started on the 25th and not the 24th in Charlottesville, same Time-Zone as New York (America/Charlottesville not being a valid Time-Zone name). Signed-off-by: Romain Tartière <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4669bc2 - Browse repository at this point
Copy the full SHA 4669bc2View commit details -
Adjust Fluent Community Meeting TZ
These one have the correct offset, but when adding `tz` we did not took this into account. Use the America/New_York offset which match the events. Signed-off-by: Romain Tartière <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 025b750 - Browse repository at this point
Copy the full SHA 025b750View commit details -
Improve wording for invalid YAML timestamps
These are not RFC822 time representations. So do not call them that name, it just add confusion. Signed-off-by: Romain Tartière <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7447dba - Browse repository at this point
Copy the full SHA 7447dbaView commit details -
Fix missing location for on-site events
Signed-off-by: Romain Tartière <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb12673 - Browse repository at this point
Copy the full SHA eb12673View commit details