Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm and Operator Release Improvements #890

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Nov 5, 2024

Description

Coming from initial PR #872.

Fix the error https://github.com/opensearch-project/opensearch-k8s-operator/actions/runs/11685891300/job/32540910915

Looking up latest tag...
Discovering changed charts since 'v2.6.0'...
WARNING: charts/opensearch-cluster/templates/Chart.yaml is missing, assuming that 'charts/opensearch-cluster/templates' is not a Helm chart. Skipping.
Nothing to do. No chart changes detected.

Since moving from stefanprodan/helm-gh-pages@master to helm/[email protected] added fetch-depth and skip_existing. The skip_existing should not throw an error if the chart with same version is already added to the gh-pages branch index.yaml file.

Here are some tests done on my fork

Release Helm Charts workflow

https://github.com/prudhvigodithi/opensearch-k8s-operator/actions/workflows/helm-release.yaml

Publish Release from tag workflow

https://github.com/prudhvigodithi/opensearch-k8s-operator/actions/runs/11687219955

Issues Resolved

Coming from #830

Check List

  • Commits are signed per the DCO using --signoff
  • Unittest added for the new/changed functionality and all unit tests are successful
  • Customer-visible features documented
  • No linter warnings (make lint)

If CRDs are changed:

  • CRD YAMLs updated (make manifests) and also copied into the helm chart
  • Changes to CRDs documented

Please refer to the PR guidelines before submitting this pull request.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi prudhvigodithi self-assigned this Nov 5, 2024
@prudhvigodithi prudhvigodithi changed the title (2nd PR) Decouple Helm Release with the Operator Release Helm and Operator Release Improvements Nov 5, 2024
@prudhvigodithi prudhvigodithi merged commit beaf4fb into opensearch-project:main Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants