Add specs for Flow framework namespace #549
Conversation
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
junweid62
requested review from
dblock,
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
|
@dbwiddis Could you please take a look at this PR when you have a chance? I would appreciate your feedback. Thanks! |
|
Not sure why CI is not running, rebase this vs. main. |
refactor: 1.add epilogues that deletes the workflow if it was created. 2.rewrite all the 'whether' 3. remove empty lines 4. add validation enum Signed-off-by: Junwei Dai <[email protected]>
There was a problem hiding this comment.
Initial pass, identified some issues to fix. Will review in more detail after next updates.
Great job on initial documentation! For someone who didn't even know what this plugin did a few weeks ago you've done a great job of documenting it (and finding some missing documentation!).
| '201': | ||
| $ref: '#/components/responses/flow_framework.create' |
There was a problem hiding this comment.
Pretty sure there are some 4xx responses for invalid template parsing:
- 400 here if max limit reached: https://github.com/opensearch-project/flow-framework/blob/b3f9d6514d2c0530c8bffac654fe175452673169/src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L223
- 400 here if provisioning failed due to an invalid workflow https://github.com/opensearch-project/flow-framework/blob/b3f9d6514d2c0530c8bffac654fe175452673169/src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java#L282
- Several more 400s in
RestCreateWorkflowActionclass for invalid params or combinations of params, etc.
There was a problem hiding this comment.
Will add in the next revision
add version to flow framework and test Signed-off-by: Junwei Dai <[email protected]>
add delete path param, add delete test, would also delete the workflow previously created Signed-off-by: Junwei Dai <[email protected]>
Add schema for 4xx response Signed-off-by: Junwei Dai <[email protected]>
Add eslint ignore 'reprovision' Signed-off-by: Junwei Dai <[email protected]>
|
@junweid62 the CI is still not working, noticed your branch is pretty far off upstream main, lmk if you need help with that |
|
I have fetch upstream in main and checkout to my branch. and then i |
Description
Part of Adding missing API specs [#168]
Issues Resolved
#508
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.