-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the notification_setting test by giving a obedient slack url #961
Fix the notification_setting test by giving a obedient slack url #961
Conversation
Signed-off-by: bowenlan-amzn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
========================================
Coverage 63.37% 63.37%
========================================
Files 341 341
Lines 11554 11554
Branches 2243 2112 -131
========================================
Hits 7322 7322
Misses 3658 3658
Partials 574 574 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-961-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e855cb5f9d8140c230e18bfc765096cfa0c7b8ce
# Push it to GitHub
git push --set-upstream origin backport/backport-961-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x Then, create a pull request where the |
…nsearch-project#961) Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit e855cb5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Fix the notification_setting test by giving a obedient slack url
regression from opensearch-project/notifications#814
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.