[Backport 2.x] add sample templates for text to visualziation (#936) #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #969 +/- ##
=========================================
Coverage 78.08% 78.08%
Complexity 993 993
=========================================
Files 99 99
Lines 4617 4617
Branches 431 431
=========================================
Hits 3605 3605
Misses 832 832
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
* add sample templates for text to visualziation Signed-off-by: Yulong Ruan <[email protected]> * update text to visualziation prompt Signed-off-by: Yulong Ruan <[email protected]> * Update CHANGELOG Signed-off-by: Yulong Ruan <[email protected]> * trailing whitespace Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]>
dbwiddis
force-pushed
the
backport-936-to-2.x
branch
from
8549d9a
to
5af2c4c
Compare
|
DCO was failing on the backport because author and DCO signoff emails differed: Reset the author on the cherry-picked commit to match DCO, but in the future @ruanyl would be helpful if you use the same email you're committing with as your DCO signature. |
owaiskazi19
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e259c12 from #936