some fixes to jira source #5203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxwell Brown <[email protected]>
Signed-off-by: Maxwell Brown <[email protected]>
Signed-off-by: Maxwell Brown <[email protected]>
Signed-off-by: Maxwell Brown <[email protected]>
Galactus22625
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
Signed-off-by: Maxwell Brown <[email protected]>
kkondaka
reviewed
Nov 25, 2024
| futureList.add(crawlerTaskExecutor.submit(() -> | ||
| service.getJiraEntities(sourceConfig, lastPollTime, itemInfoQueue), false)); | ||
| } | ||
|
|
There was a problem hiding this comment.
These changes look good but I do not see corresponding changes to the JavaIteratorTest.java file. When using futures testing is very important as we realized with Lambda code. Please make sure all these changes have corresponding tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit: Prevent Polling when there is already a leader scheduler
Stop race condition which causes jira pipeline to infinitely write to open search on loop because lastpolltime doesnt get updated properly
Commit: verify internet address everytime we invoke restapi
addresses appsec finding in osc-02 where we have a (TOCATOU) time of checkout time of use vulnerability
Commit: re-parallelize crawler call
re-parallelizing initial pagination and child partition so that we don’t have high latency at the start where we wait to crawl all pages before we start writing documents
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.