Improve logging for failed documents in the OpenSearch sink #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
LoggingImprovements
branch
from
36a12b3
to
85ea11d
Compare
asifsmohammed
approved these changes
Sep 27, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit 63695e9)
asifsmohammed
pushed a commit
that referenced
this pull request
Sep 27, 2023
…3389) Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit 63695e9) Co-authored-by: Taylor Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are logs in the OpenSearch sink that are censored, and not helpful for failure to write to opensearch or the dlq.
Improves the logging of failure to write with error code and message
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.