Add Dissect Processor #3363
Merged
Add Dissect Processor #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Boinapalli <[email protected]>
Signed-off-by: Vishal Boinapalli <[email protected]>
Signed-off-by: Hai Yan <[email protected]>
oeyh
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
dlvenable
as code owners
Signed-off-by: Hai Yan <[email protected]>
graytaylor0
reviewed
Sep 20, 2023
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class FieldHelper { |
There was a problem hiding this comment.
Looks like some missing unit tests on this class.
| import java.util.regex.Pattern; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class Dissector { |
There was a problem hiding this comment.
Looks like this class has no unit tests and is being tested indirectly in DissectProcessorTest. Ideally we would mock this class and have unit tests for it directly, but I won't block the PR on that
There was a problem hiding this comment.
Makes sense. I separated the tests for Dissector from DissectProcessorTest. DissectProcessorTest now only tests things after the actual dissection is done - e.g., handle dissect exception, convert type, and put dissected fields into event.
…essor; add delimiter and fieldhelper tests Signed-off-by: Hai Yan <[email protected]>
graytaylor0
approved these changes
Sep 21, 2023
kkondaka
approved these changes
Sep 26, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved commits from #3090 by @vishalboin, rebased to resolve merge conflicts and made some small tweaks on tests and docs.
Issues Resolved
Resolves #3362
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.