-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fine-grained provisioning; handle more edge cases on search flow #268
Merged
ohltyler
merged 6 commits into
opensearch-project:main
from
ohltyler:fine-grained-provisioning
Aug 7, 2024
Merged
Support fine-grained provisioning; handle more edge cases on search flow #268
ohltyler
merged 6 commits into
opensearch-project:main
from
ohltyler:fine-grained-provisioning
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch index configs; add fine-grained validation Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang and
minalsha
as code owners
August 6, 2024 21:49
owaiskazi19
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG overall with few styling comments
public/pages/workflow_detail/workflow_inputs/workflow_inputs.tsx
Outdated
Show resolved
Hide resolved
public/pages/workflow_detail/workflow_inputs/workflow_inputs.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
owaiskazi19
approved these changes
Aug 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
…low (#268) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 1e4127c)
ohltyler
added a commit
that referenced
this pull request
Aug 7, 2024
…low (#268) (#269) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 1e4127c) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the search flow by allowing fine-grained provisioning (creating a search pipeline and attaching to an existing index) instead of the limitation from before, forcing full index deletion and re-creation. Now data is persisted and can be searched on in the search flow end-to-end. Additionally, cleans up some edge cases and improves the search flow experience overall, making it fully functional end-to-end now.
More details:
reprovision
parameter on the update workflow API call to support fine-grained provisioning (ref: Adds reprovision API to support updating search pipelines, ingest pipelines index settings flow-framework#804)Testing:
Tested following scenarios:
Demo video, showing fine-grained provisioning happening on the search side. We provision an ingest pipeline & index, then on search, configure and provision a search pipeline separately, but keeping the existing ingest resources. Notice the search call made after running, and how data is still present. Lastly, shows that selecting different indices (if ingest is disabled) is persisted in the UI.
screen-capture.21.webm
Issues Resolved
Makes progress on #23
Resolves #267
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.