Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the arithmetic long overflow exception with null date values. #16796

Closed
wants to merge 1 commit into from

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Dec 6, 2024

Description

  • Early termination by checking PointValues.size() before any date parsing, If there are no points in the segment, we return DISJOINT immediately.
  • Avoid attempting to parse dates when there's no data.
  • This prevents the arithmetic overflow that would occur when trying to parse null/empty dates.

Pending to add unit tests.

Related Issues

Related Issue #16709 and coming from #16709 (comment)

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

❕ Gradle check result for a28c8cc: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.89%. Comparing base (3eecea4) to head (a28c8cc).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16796      +/-   ##
============================================
+ Coverage     71.74%   71.89%   +0.15%     
- Complexity    65420    65504      +84     
============================================
  Files          5314     5314              
  Lines        305364   305364              
  Branches      44501    44501              
============================================
+ Hits         219077   219549     +472     
+ Misses        67952    67501     -451     
+ Partials      18335    18314      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi
Copy link
Member Author

Closing this based on the comment here #16709 (comment).

Copy link
Contributor

github-actions bot commented Dec 8, 2024

❌ Gradle check result for 5378859: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant