[Flaky Test] Fix Flaky Test SearchWithRandomExceptionsIT.testRandomExceptions #16737
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
kkewwei
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
>test-failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16737 +/- ##
============================================
+ Coverage 72.00% 72.14% +0.14%
- Complexity 65159 65223 +64
============================================
Files 5318 5318
Lines 303983 303983
Branches 43986 43986
============================================
+ Hits 218892 219322 +430
+ Misses 67148 66711 -437
- Partials 17943 17950 +7 ☔ View full report in Codecov by Sentry. |
reta
reviewed
Nov 28, 2024
...r/src/internalClusterTest/java/org/opensearch/search/basic/SearchWithRandomExceptionsIT.java
Show resolved
Hide resolved
reta
approved these changes
Nov 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
) Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]> (cherry picked from commit b75f27a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Nov 29, 2024
) (#16746) (cherry picked from commit b75f27a) Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the index refresh may fail, so the translog in the index will be not flushed, and
TranslogWriter.bufferis not null, which causes arrays not been released, so we need to close the index to release the arrays.Why
TransportSearchFailuresIT.testFailedSearchWithWrongQueryis successfully is the refreshing index is successful.Related Issues
Resolves #15828
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.