Use equalsTo() for string comparison instead of == #16714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR opensearch-project#16461 Signed-off-by: Dmitry Kryukov <[email protected]>
dk2k
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16714 +/- ##
============================================
- Coverage 72.51% 72.12% -0.40%
+ Complexity 65562 65205 -357
============================================
Files 5318 5318
Lines 303945 303945
Branches 43976 43976
============================================
- Hits 220413 219221 -1192
- Misses 65798 66790 +992
- Partials 17734 17934 +200 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| @@ -126,7 +126,7 @@ public void add(Term[] terms) { | |||
| */ | |||
| public void add(Term[] terms, int position) { | |||
| for (int i = 0; i < terms.length; i++) { | |||
| if (terms[i].field() != field) { | |||
| if (!Objects.equals(terms[i].field(), field)) { | |||
There was a problem hiding this comment.
field is a non-nullable object. Why not directly use field.equals(..)?
| @@ -105,7 +106,7 @@ public List<String> resolveIndexAbstractions( | |||
|
|
|||
| // we always need to check for date math expressions | |||
| final String dateMathName = indexNameExpressionResolver.resolveDateMathExpression(indexAbstraction); | |||
| if (dateMathName != indexAbstraction) { | |||
| if (!Objects.equals(dateMathName, indexAbstraction)) { | |||
There was a problem hiding this comment.
I don't think either of the 2 is null - can you verify once. If they are non-null than s1.equals(s2) will be slightly (unnoticeable but still) faster.
| @@ -105,7 +106,7 @@ public List<String> resolveIndexAbstractions( | |||
|
|
|||
| // we always need to check for date math expressions | |||
| final String dateMathName = indexNameExpressionResolver.resolveDateMathExpression(indexAbstraction); | |||
| if (dateMathName != indexAbstraction) { | |||
| if (!Objects.equals(dateMathName, indexAbstraction)) { | |||
| assert dateMathName.equals(indexAbstraction) == false; | |||
There was a problem hiding this comment.
I'm wondering why do we even need this assertion. Why can remove this since that's the entry criteria in this block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #16461
Got spoiled because of rebase