Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Ensure support of the transport-nio by security plugin (HTTP) (#16474) #16565

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 5, 2024

Backport of #16474 to 2.x

…arch-project#16474)

* Ensure support of the transport-nio by security plugin (HTTP)

Signed-off-by: Andriy Redko <[email protected]>

* Add header verifier and decompressor support of secure NIO transport variant

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit b25e10a)
Copy link
Contributor

github-actions bot commented Nov 5, 2024

❌ Gradle check result for dad027f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Nov 5, 2024

@andrross if you don't mind this backport please, thank you!

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Gradle check result for dad027f: SUCCESS

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 68.91892% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (2fa8370) to head (dad027f).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ain/java/org/opensearch/http/nio/ssl/SslUtils.java 0.00% 13 Missing ⚠️
...rg/opensearch/http/nio/NioHttpServerTransport.java 87.17% 3 Missing and 2 partials ⚠️
...g/opensearch/transport/nio/NioTransportPlugin.java 0.00% 3 Missing ⚠️
.../org/opensearch/http/nio/HttpReadWriteHandler.java 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16565      +/-   ##
============================================
- Coverage     71.95%   71.76%   -0.20%     
+ Complexity    65440    65387      -53     
============================================
  Files          5312     5313       +1     
  Lines        305033   305098      +65     
  Branches      44443    44452       +9     
============================================
- Hits         219475   218939     -536     
- Misses        67269    67912     +643     
+ Partials      18289    18247      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 047e78e into opensearch-project:2.x Nov 5, 2024
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.19.0 Issues and PRs related to version 2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants