Modify flaky test testRemotePublicationDisabledByRollingRestart

[shiv0408]

Description

Remove assertion on incompatible Diff Received is 0 after cluster manager flipped, as it is possible that one of nodes lags and receives a incompatible diff, then requests for full state after remote publication is disabled and we have shifted to publication on transport.

Ran the test 7k times to ensure no flakiness in the test.

./gradlew ':server:internalClusterTest' --tests "org.opensearch.gateway.remote.RemoteStatePublicationIT.testRemotePublicationDisabledByRollingRestart" -Dtests.iters=10000 -Dtests.timeoutSuite=6000000!
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.10
  OS Info               : Linux 6.1.106-116.188.amzn2023.x86_64 (amd64)
  JDK Version           : 17 (Amazon Corretto JDK)
  JAVA_HOME             : /usr/lib/jvm/java-17-amazon-corretto.x86_64
  Random Testing Seed   : 290AD55D5B347224
  In FIPS 140 mode      : false
=======================================

> Task :server:compileJava
Note: Processing Log4j annotations
Note: Annotations processed
Note: Processing OpenSearch Api annotations
Note: Processing Log4j annotations
Note: No elements to process
Note: Processing OpenSearch Api annotations
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :test:framework:compileJava
Note: Processing Log4j annotations
Note: Annotations processed
Note: Processing Log4j annotations
Note: No elements to process
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :server:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :server:compileInternalClusterTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/home/ec2-user/OpenSearch/test/framework/build/distributions/framework-3.0.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
<============-> 99% EXECUTING [2h 32m 47s]
> :server:internalClusterTest > 7020 tests completed
> :server:internalClusterTest > Executing test org.opensearch.gateway.remote.RemoteStatePublicationIT

Related Issues

Resolves #15767

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for b2dd6e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[shiv0408]

❌ Gradle check result for b2dd6e3: FAILURE

org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks - #14599

[github-actions]

❌ Gradle check result for b2dd6e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[shiv0408]

❌ Gradle check result for b2dd6e3: FAILURE

org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction - #14304

[github-actions]

❌ Gradle check result for b2dd6e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[shiv0408]

❌ Gradle check result for b2dd6e3: FAILURE

Flaky tests #14291
org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.classMethod

[github-actions]

❌ Gradle check result for b2dd6e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for a223e68: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.78%. Comparing base (92d7fe8) to head (a223e68).
Report is 49 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15854      +/-   ##
============================================
- Coverage     71.90%   71.78%   -0.12%     
+ Complexity    64216    64157      -59     
============================================
  Files          5272     5272              
  Lines        300597   300597              
  Branches      43440    43440              
============================================
- Hits         216151   215795     -356     
- Misses        66680    67068     +388     
+ Partials      17766    17734      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15854-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0617d95c0e3185c4d5dd38fc9d1637da1b11b0ab
# Push it to GitHub
git push --set-upstream origin backport/backport-15854-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15854-to-2.x.