Fix flakiness in testDontAllowSwitchingCompatibilityModeForClusterWit… #13281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hMultipleVersions Signed-off-by: Lakshya Taragi <[email protected]>
github-actions
bot
added
bug
ltaragi
added
skip-changelog
and removed
bug
github-actions
bot
added
bug
|
❌ Gradle check result for 8701a41: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
ltaragi
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159 and
sachinpkale
as code owners
ltaragi
requested review from
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13281 +/- ##
============================================
- Coverage 71.48% 71.43% -0.05%
+ Complexity 60670 60655 -15
============================================
Files 5040 5040
Lines 285456 285456
Branches 41338 41338
============================================
- Hits 204044 203905 -139
- Misses 64589 64705 +116
- Partials 16823 16846 +23 ☔ View full report in Codecov by Sentry. |
gbbafna
approved these changes
Apr 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…hMultipleVersions (#13281) Signed-off-by: Lakshya Taragi <[email protected]> (cherry picked from commit 61ff5f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Apr 19, 2024
…hMultipleVersions (#13281) (#13287) (cherry picked from commit 61ff5f8) Signed-off-by: Lakshya Taragi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hMultipleVersions
Description
org.opensearch.action.support.clustermanager.TransportClusterManagerNodeActionTests.testDontAllowSwitchingCompatibilityModeForClusterWithMultipleVersions.randomCompatibleVersion(random(), version1)to pickversion2which does not guaranteeversion2being different fromversion1leading to an assertion failure atassert version1.equals(version2) == falseRelated Issues
Resolves #13240
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.