-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert issue and bug templates to use forms #11534
Conversation
While we are at it - Do you think it makes sense to add in a flaky test form as well? |
This comment was marked as outdated.
This comment was marked as outdated.
I forgot I had cut this from main so that i could test it from my fork and reset that branch causing this to get closed. Should be restored now - @anasalkouz mind taking another look before this is merged? |
This comment was marked as outdated.
This comment was marked as outdated.
❌ Gradle check result for f7cdfaf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5102640: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
❌ Gradle check result for 821ad93: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Marc Handalian <[email protected]>
|
|
|
❌ Gradle check result for e4a1e03: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ac8eab6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for ac8eab6: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@peternied I see you self-assigned this. Do you want to review/approve it? |
Thanks for checking in @andrross - I have been adding myself as 'assigned' to make it easier to track PRs that I'm actively reviewing - but I won't mind if it was merged since I didn't request changes. 🤞 this workflow won't be need after the personalization changes [1] are in. |
Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This converts bug and feature request templates to forms that require users to select a label. The added workflow will trigger after the issue cut and apply the actual label to the issue based on the value selected.
This is a continuation of #11178 cherry picked from @bowenlan-amzn's fork.
The commit I added sorts the label values and adds a description alerting users to select "Other" if they don't know which label to select.
Tested both on my fork with these issues:
Feature request
Bug
Related Issues
Resolves #10901
Check List
All tests passNew functionality has been documented.New functionality has javadoc addedCommits are signed per the DCO using --signoffCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.